Develop #312
Closed
Develop #312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| @anu1097 thanks you contributions, it's welcome to join us for a contributors, I really need contributors for this project. Contact me by my emails: allen@shopback.com . I will let you know how we progress this project. For this PR, I will review in next couple days. |
AllenFang reviewed Apr 29, 2018
| @@ -1,4 +1,5 @@ | |||
| export default { | |||
| STYLE: {}, | |||
There was a problem hiding this comment.
I think it's a little not make sense to define a style object as a constant variable, you can just remove it and defined in the component
| @anu1097 btw, please change the branch to |
| Hey all, I'm interested in this feature. Any idea when it will be PR'd into develop and then released? |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I have tried to add a feature to show the pagination panel on top of the table. Just used a simple hack.
For this feature request/issue -
"Configuration to show pagination buttons above table rather than below the table. #299"
If this hack is not good enough or you want to provide more functionality to users to customize or play with pagination panel's behaviour then I up for the development work.
I am a big fan of your work. P.S. this is my first Pull request and want to contribute further and I am looking forward to your feedback