Add rowKey to selection cell renderer #1358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
AllenFang approved these changes May 17, 2020
| release to newest version done |
This was referenced Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Re-opening #1139 to correct the branches.
Original PR text:
I was writing a custom renderer for the selection cell in order to add a label to the input for screen readers. But I realized that the
rowIndexbeing passed in cannot reliably be used to get the row data, since filtering and sorting affect it.This change merely adds the
rowKeyas an additional param to customselectionRendererfunctions.