Skip to content

Conversation

@ptosco
Copy link
Collaborator

@ptosco ptosco commented Nov 19, 2024

This PR contains the 2024_09_2 RDKit binaries and JARs including the fix for #8019.
@greglandrum Thank you on behalf of Manuel for a quick review!

EDIT: yesterday I omitted to rebase my branch ahead of pushing, which is why I had to force-push this morning. Now it is good to go.

@ptosco ptosco force-pushed the fix-missing-distance-constraint-contrib branch from c0b6a1e to 683642c Compare November 20, 2024 08:42
@manuelschwarze manuelschwarze self-requested a review November 20, 2024 08:57
@manuelschwarze
Copy link
Contributor

Tested successfully by me on Linux, Windows and Mac (Intel). From my side ready to merge.

Copy link
Member

@greglandrum greglandrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@ptosco and I talked about this yesterday

@manuelschwarze manuelschwarze merged commit 31497cd into nightly_pre5.3 Nov 20, 2024
@greglandrum greglandrum deleted the fix-missing-distance-constraint-contrib branch November 20, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4 participants