KNIME-1792: RDKit 2023_09_2 Binaries Update and Bugfixes (for issue #143) #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…_RW4LHiDKIJVt8dK077EKF75taX4o8e1nri2I@github.com/ptosco/knime-rdkit into nightly_pre4.7_2023_09_2
RDKit Binaries updated to 2023_09_2
Some plugins that the RDKit Nodes Wizard requires have a dependency on javax.annotation, which was fulfilled in lower Java versions automatically, but not anymore when using Java 17. Therefore, it is now referenced additionally.
New RDKit version understands correctly duplicates now
greglandrum approved these changes Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Automated tests were running successfully on Windows, Linux and Mac. One Mac one of the SVG tests delivered slightly different results, but this had happened in the past and was accepted.
This code will get merged first to nightly_pre4.7, and from there I will cherry-pick all meaningful changes to get into the master (for KNIME 4.7+).