wait ttl seconds added #4118
Open
wait ttl seconds added #4118
+138 −0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Signed-off-by: ujjawal-khare <khareu460@gmail.com>
ujjawal-khare-27 requested review from MortalHappiness, andrewsykim, kevin85421 and rueian as code owners Signed-off-by: ujjawal-khare <khareu460@gmail.com>
Signed-off-by: ujjawal-khare <khareu460@gmail.com>
Signed-off-by: ujjawal-khare <khareu460@gmail.com>
Signed-off-by: ujjawal-khare <khareu460@gmail.com>
Future-Outlier requested changes Oct 15, 2025
There was a problem hiding this comment.
Sorry, I remembered that this PR is not going to be added,
cc @EagleLo do you remember the reason?
Schedulers (ex: Volcano, YuniKorn, Kueue, scheduler-plugins, KAI scheduler ... etc) should ensure the gang scheduling. |
| @Future-Outlier Last time we discussed that since this applies to InteractiveMode, it's up to the user to decide when to stop or clean up the job. So we decided not to enforce a hard cutoff time in this case. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Added a param WaitingTtlSeconds to Ray job. WaitingTtlSeconds is the TTL to mark RayJob as failed when it is waiting to be scheduled.
Related issue number
Closes #4037
Checks