Add support for Adafruit QTPy RP2040 (and other boards) #18

smittytone · 2021-08-06T07:37:18Z

I'm not offering this for merging per se, more to see if you're interested in pull in updates like this: to support other RP2040-based devices.

Happy to make changes too.

Cheers,

Tony

CMakeLists.txt

src/picoprobe_config.h

CMakeLists.txt

smittytone · 2021-08-10T10:24:12Z

Updated with better device selection: the user sets the value of USE_QTPY in CMakeLists.txt and CMake config and then building, etc. proceed accordingly. Default is Picoprobe on Pico (USE_QTPY == 0)

CMakeLists.txt

thezim · 2021-09-03T21:41:09Z

I think using the default board defines instead of a new define is a better route. On most of the existing boards define PICO_DEFAULT_I2C_SDA_PIN map to the STEMMA/QWIIC connector already and hard definitions in picoprobe are not needed. Defining PICO_BOARD sets it all in motion, see section 2.6.1. Preprocessor Variables via Board Configuration File of the SDK documentation.

Here is an example I tested.

#ifdef ADAFRUIT_QTPY_RP2040 || SPARKFUN_PROMICRO #define PROBE_PIN_OFFSET PICO_DEFAULT_I2C_SDA_PIN #else #define PROBE_PIN_OFFSET 2 #endif

However PICO_DEFAULT_LED_PIN becomes undefined. But on the plus sided PICO_DEFAULT_WS2812_PIN is defined for board that have them. Some boards like the SparkFun Thing Plus has both and in that case I say the the default LED should be used. I have not dug too deep but there may be boards with no available LED, regular to WS281x. The WS281x only is a case to like it is for my SparkFun Pro Micro.

kilograham · 2021-09-04T01:07:50Z

yes, better to use the default pin defines so it works on everything
PICO_DEFAULT_WS2812_PIN and PICO_DEFAULT_LED_PIN should be defined on all boards that have them and undefined on those that don't.
Some of the examples to do with toggling LED pins for example will output a compiler warning on boards that don't have a LED pins

There is also a placeholder issue raspberrypi/pico-sdk#188 to create a simple abstraction for signaling status/something on either LED or WS2812

smittytone · 2021-09-11T11:35:27Z

As per above, I've updated config to use PICO_BOARD as the initialisation point, with the standard value entered there to define what's needed for a specific board. I've added a couple more — @dhalbert’s SparkFun Pro Micro and the Adafruit Feather, the focus being on boards I have with STEMMA ports — and made use of SDK-set #define values wherever possible. One case were it's not: the GPIO pin number for SWD CLK on the QTPy which is not the same as the standard SDA pin.

I've also brought the RGB LED colour setting into CMakeLists.txt to reduce the number of edits a user might have to make to other files if they're building for a known board.

Added a Read Me too, as that's what I do for a living.

PS. I've crudely 'fixed' the undefined PICO_DEFAULT_LED_PIN issue, but there must be better approach that doesn't send folk to the command line, surely?

lurch · 2021-09-12T10:12:36Z

CMakeLists.txt

+endif()
+
+if (NOT PICO_BOARD STREQUAL "pico")
+ target_sources(${EXECUTABLE_NAME} PRIVATE src/ws2812.c)


This seems to be assuming that any board which isn't a Raspberry Pi Pico will always have a WS2812 LED, which I guess won't always be the case? Probably better to do something like set(HAS_WS2812 1) in the bit above where you're checking individual board-names?

lurch · 2021-09-12T10:15:45Z

README.md

@@ -0,0 +1,25 @@
+# Picoprobe
+
+A Picoprobe is a Raspberry Pi RP2040-based Single-Wire Debug (SWB) adaptor. You can make one from a Raspberry Pi Pico — hence the name — or almost any third-party RP2040-based board. Use it to connect your RP2040-based application board to your personal computer for debugging through `gdb`, directly or via an IDE such as Microsoft Visual Studio Code.


Single-Wire Debug -> Serial Wire Debug
SWB -> SWD

lurch · 2021-09-12T10:19:51Z

README.md

+
+A Picoprobe is a Raspberry Pi RP2040-based Single-Wire Debug (SWB) adaptor. You can make one from a Raspberry Pi Pico — hence the name — or almost any third-party RP2040-based board. Use it to connect your RP2040-based application board to your personal computer for debugging through `gdb`, directly or via an IDE such as Microsoft Visual Studio Code.
+
+The original version of this code only supported the Pico. This update adds support for three more boards, each of which provides a [STEMMA QT connector](https://learn.adafruit.com/introducing-adafruit-stemma-qt/what-is-stemma-qt)/[Quicc](https://www.sparkfun.com/qwiic) for easy cabling to the application board under test. These connectors are intended for use with I&sup2;C devices, but here we’re using their pins for GPIO and power.


I don't think it makes sense for README.md to talk about "This update..." ? (this is the README, not a CHANGELOG)
Quicc -> Qwiic ?

I think what is worth mentioning is the that if you are using the STEMMA/Qwiic board is that UART lines will not be passed through. Using the base board has that advantage as you don't need to plug in both your pico probe and the target board to USB.

lurch · 2021-09-12T10:20:29Z

README.md

+
+The original version of this code only supported the Pico. This update adds support for three more boards, each of which provides a [STEMMA QT connector](https://learn.adafruit.com/introducing-adafruit-stemma-qt/what-is-stemma-qt)/[Quicc](https://www.sparkfun.com/qwiic) for easy cabling to the application board under test. These connectors are intended for use with I&sup2;C devices, but here we’re using their pins for GPIO and power.
+
+The code also uses the WS2812 RGB LED on those boards that have one as an SWD activity indicator.


Perhaps "on those boards that have one" should be in parentheses?

lurch · 2021-09-12T10:21:19Z

README.md

+
+The code also uses the WS2812 RGB LED on those boards that have one as an SWD activity indicator.
+
+If your chosen board is not one of those so far supported by the Picoprobe code, you should be able to use with just a few small code changes.


use with -> use it with ?

lurch · 2021-09-12T10:21:59Z

README.md

+
+## Build the Picoprobe code
+
+To build for your own Picoprobe:


"To build Picoprobe for your own board:" ?

lurch · 2021-09-12T10:23:47Z

CMakeLists.txt

+ message("Building for Adafruit Feather RP2040 with WS2812")
+elseif (PICO_BOARD STREQUAL "sparkfun_promicro")
+ message("Building for SparkFun Pro Micro RP2040 with WS2812")
+else()


Should this else() be elseif (PICO_BOARD STREQUAL "pico") ?

lurch · 2021-09-12T10:31:03Z

src/picoprobe_config.h

 #ifndef PICO_DEFAULT_LED_PIN
-#error PICO_DEFAULT_LED_PIN is not defined, run PICOPROBE_LED=<led_pin> cmake
+// #error PICO_DEFAULT_LED_PIN is not defined, run PICOPROBE_LED=<led_pin> cmake
+#define PICOPROBE_LED 0 // To avoid compiler errors -- is there a better way to do this?


Perhaps you want something like #if !defined(PICO_DEFAULT_LED_PIN) && !defined(PICO_DEFAULT_WS2812_PIN) ?

thezim · 2021-09-12T20:11:49Z

CMakeLists.txt

+# "adafruit_feather_rp2040" for the Adafruit Feather RP2040
+# "sparkfun_promicro" for the SparkFun Pro Micro RP2040
+
+set(PICO_BOARD "pico")


Should this be defined in this file? A PICO_BOARD environment variable works too. Not having to modify any files make building even easier.

Linux/MacOS

export PICO_BOARD=SPARKFUN_PROMICRO cmake .

WIndows

SET PICO_BOARD=SPARKFUN_PROMICRO cmake .

PowerShell Core (All OS'es)

$env:PICO_BOARD=SPARKFUN_PROMICRO cmake .

thezim · 2021-09-12T20:14:10Z

README.md

+
+To build for your own Picoprobe:
+
+1. Edit the `CmakeLists.txt` file and change the value of `PICO_BOARD` in line 16.


Line number change over time. Better to reference this by name and not by line number. Less work later.

lurch · 2021-09-13T12:23:31Z

Why was this closed @smittytone ?

smittytone · 2021-09-14T08:55:57Z

I've closed it because I don't think it's getting anywhere. I opened the request to see if there was any interest on the part of the Foundation in extending this. That question hasn't been answered. I've had some useful suggestions for improvements, which I have applied, and a fair few opinions, but nothing in the way of direction, and I think that's what is required at this stage. Someone with the authority to do so needs to set a framework for how other devices get added, and oversee their addition as punters submit them. I proposed one approach, and anyone can view my fork to see how it works. I'm open to others, and I'm also happy to reopen this PR if the Foundation thinks that's the way to go.

lurch · 2021-09-14T09:24:16Z

ping @kilograham and @liamfraser

smittytone added 8 commits July 23, 2021 16:50

Mask build directory

2dc1e2a

Add WS2812 driver code

e9bbdae

Add WS2812 includes etc.

4cd2bc7

Correct original settings

62ab7e0

Correct original settings part deux

211f805

Fix a compile warning when USE_WS2812 not set

0f32bcb

Tweakette

99598c7

Improve colour handling

2f8006d

lurch reviewed Aug 6, 2021

View reviewed changes

CMakeLists.txt Outdated Show resolved Hide resolved

lurch reviewed Aug 6, 2021

View reviewed changes

CMakeLists.txt Outdated Show resolved Hide resolved

lurch reviewed Aug 6, 2021

View reviewed changes

src/picoprobe_config.h Outdated Show resolved Hide resolved

lurch reviewed Aug 6, 2021

View reviewed changes

src/picoprobe_config.h Outdated Show resolved Hide resolved

smittytone added 4 commits August 8, 2021 12:34

Review-suggested changes

43644c4

Disable QTPy support as standard; separate SWD and WS2812

177f709

Tweak comment

ac87ba0

Fix issues added by previous over-zealous push

5db5646

lurch reviewed Aug 9, 2021

View reviewed changes

CMakeLists.txt Outdated Show resolved Hide resolved

alternative cmakelists.txt

d8d7553

lurch reviewed Aug 10, 2021

View reviewed changes

CMakeLists.txt Outdated Show resolved Hide resolved

lurch reviewed Aug 10, 2021

View reviewed changes

CMakeLists.txt Outdated Show resolved Hide resolved

Change congig vars to strings; fix typo

02121f3

smittytone added 5 commits September 10, 2021 20:49

Add Feather RP2040; Pro Micro RP2040

24f870c

Move LED colour setter here

8d0299e

Small code tweaks

c9bd543

Use SDK standard defines wherever possible

03f406a

Textual improvements

c8e644e

smittytone changed the title ~~Add support for Adafruit QTPy RP2040~~ Add support for Adafruit QTPy RP2040 (and other boards) Sep 11, 2021

lurch reviewed Sep 12, 2021

View reviewed changes

smittytone closed this Sep 12, 2021

thezim reviewed Sep 12, 2021

View reviewed changes

lurch mentioned this pull request Sep 20, 2021

Add support for other RP2040-based boards #21

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add support for Adafruit QTPy RP2040 (and other boards) #18

Add support for Adafruit QTPy RP2040 (and other boards) #18

Uh oh!

smittytone commented Aug 6, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

smittytone commented Aug 10, 2021

Uh oh!

Uh oh!

thezim commented Sep 3, 2021

kilograham commented Sep 4, 2021

smittytone commented Sep 11, 2021

lurch Sep 12, 2021

lurch Sep 12, 2021

lurch Sep 12, 2021

thezim Sep 12, 2021

lurch Sep 12, 2021

lurch Sep 12, 2021

lurch Sep 12, 2021 •

edited

Loading

lurch Sep 12, 2021

lurch Sep 12, 2021

thezim Sep 12, 2021

thezim Sep 12, 2021

lurch commented Sep 13, 2021

smittytone commented Sep 14, 2021

lurch commented Sep 14, 2021

Labels

5 participants

		@@ -0,0 +1,25 @@
		# Picoprobe

		A Picoprobe is a Raspberry Pi RP2040-based Single-Wire Debug (SWB) adaptor. You can make one from a Raspberry Pi Pico — hence the name — or almost any third-party RP2040-based board. Use it to connect your RP2040-based application board to your personal computer for debugging through `gdb`, directly or via an IDE such as Microsoft Visual Studio Code.


		A Picoprobe is a Raspberry Pi RP2040-based Single-Wire Debug (SWB) adaptor. You can make one from a Raspberry Pi Pico — hence the name — or almost any third-party RP2040-based board. Use it to connect your RP2040-based application board to your personal computer for debugging through `gdb`, directly or via an IDE such as Microsoft Visual Studio Code.

		The original version of this code only supported the Pico. This update adds support for three more boards, each of which provides a [STEMMA QT connector](https://learn.adafruit.com/introducing-adafruit-stemma-qt/what-is-stemma-qt)/[Quicc](https://www.sparkfun.com/qwiic) for easy cabling to the application board under test. These connectors are intended for use with I²C devices, but here we’re using their pins for GPIO and power.


		The original version of this code only supported the Pico. This update adds support for three more boards, each of which provides a [STEMMA QT connector](https://learn.adafruit.com/introducing-adafruit-stemma-qt/what-is-stemma-qt)/[Quicc](https://www.sparkfun.com/qwiic) for easy cabling to the application board under test. These connectors are intended for use with I²C devices, but here we’re using their pins for GPIO and power.

		The code also uses the WS2812 RGB LED on those boards that have one as an SWD activity indicator.


		The code also uses the WS2812 RGB LED on those boards that have one as an SWD activity indicator.

		If your chosen board is not one of those so far supported by the Picoprobe code, you should be able to use with just a few small code changes.


		To build for your own Picoprobe:

		1. Edit the `CmakeLists.txt` file and change the value of `PICO_BOARD` in line 16.

Add support for Adafruit QTPy RP2040 (and other boards) #18

Add support for Adafruit QTPy RP2040 (and other boards) #18

Uh oh!

Conversation

smittytone commented Aug 6, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

smittytone commented Aug 10, 2021

Uh oh!

Uh oh!

thezim commented Sep 3, 2021

kilograham commented Sep 4, 2021

smittytone commented Sep 11, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lurch Sep 12, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lurch commented Sep 13, 2021

smittytone commented Sep 14, 2021

lurch commented Sep 14, 2021

Labels

5 participants

lurch Sep 12, 2021 •

edited

Loading