Add MS OS Descriptor 2.0 to load WinUSB automatically on Windows. #17
Conversation
| That page says "Please read the license agreement before continuing." and I'm not familiar enough with legalese to be able to tell if that licence allows Open Source implementations, so pinging @ghollingworth |
| If you want to support Windows 7 then it is better to use the old MS OS 1.0 descriptors. |
There is no official support for Windows versions before Windows 10. |
I see. In that case, MS OS 2.0 descriptor is better as it better designed. |
| I'm happy with that license |
| Hi. In this code, are there any problem which blocks to merge this PR? |
can you please match the pre-existing code style. Also despite having linked the MS spec, the descriptor is a little terse. I'm prepared to believe it works, but maybe a comment saying exactly what it is saying would be helpful. Is there anything in there that is specific/unique to picoprobe? |
| This pull request appears to be using a device interface GUID of A5DCBF10-6530-11D2-901F-00C04FB951ED, which is GUID_DEVINTERFACE_USB_DEVICE, a special GUID that Microsoft's hub drivers use. However, the device interface GUID is supposed to be a GUID indicating what type of interface this specific device has. Any application using libusb won't care about the GUID, but there is example code from Microsoft showing how to enumerate all the USB devices and then select USB devices based on their device interface GUID. If you reuse this GUID that Microsoft defined, there is some risk that applications or other drivers might connect to the picoprobe interface and expect that they are talking to a USB hub driver, but they would actually be talking to WinUSB. I recommend generating a new GUID for the picoprobe with In case you are not convinced, here is documentation from Microsoft talking about how to get WinUSB working with an INF file, and it says to generate a device interface GUID using guidgen.exe: https://docs.microsoft.com/en-us/windows-hardware/drivers/usbcon/winusb-installation The MS OS 2.0 Descriptors allow us to set up the device interface GUID using a USB descriptor instead of using an INF file, but it doesn't change the meaning of the device interface GUID. |
| Good point to use an unique GUID. A good reference is here at libwdi wiki site: https://github.com/pbatard/libwdi/wiki/WCID-Devices |
| Another choice , you can just omit GUID registry definition from the MSOS20-descriptor. |
| Superseded by #31, which implements the above (and adds the GUID that Keil specifies for DAP interfaces). |
9 participants
This PR adds MS OS Descriptor 2.0 to load WinUSB driver automatically on Windows.
MS OS 2.0 Descriptor spec is here.
https://docs.microsoft.com/en-us/windows-hardware/drivers/usbcon/microsoft-os-2-0-descriptors-specification
I've confirmed that this modification works with Windows 10 Pro 20H2, and OpenOCD can access to the picoprobe correctly.
I think this PR solves #15, because after this modification we don't need to install driver with Zadig anymore.