support k8s 1.32.2 #352
Merged
support k8s 1.32.2 #352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
brandond approved these changes Mar 5, 2025
| Seems like for some reason e2e was not running all the tests, but I'm not sure why. Logs for other recent PRs say:
For this PR we have:
|
| @jiaqiluo can you merge or do you need me to do that? |
| @brandond, thanks for sharing the findings, that at least explains why the CI passed in the past. |
thatmidwesterncoder approved these changes Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
rancher/rancher#48825
Changes:
Bump the k8s modules to 1.32.2
Bump the kubectl
Failed tests:
The
initContaineris only set whenplan.Spec.Prepare,plan.Spec.Cordon, orplan.Spec.Drainis not nil code, which doesn't seem to be the case for the plan created in these tests.