Skip to content

Fix in exception in form request classes if the php failed to get rules #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2021
Merged

Fix in exception in form request classes if the php failed to get rules #21

merged 1 commit into from
Oct 11, 2021

Conversation

Mello21century
Copy link
Contributor

Hello

Problem:
When form request rules() method call some classes reference and some PHP code that need to identify.
Solve:
Fall back to another interpreter method. called rulesByRegex()
Uses the regexp and read the file contents extracts fields and rules into the same array structure
@kevincobain2000
Copy link
Member

wow thanks!
@kevincobain2000 kevincobain2000 merged commit 319837e into rakutentech:master Oct 11, 2021
@kevincobain2000
Copy link
Member

kevincobain2000 commented Feb 9, 2022 •
edited
Loading

  1. There was a bug that I have fixed here 4de850d
  2. I have disabled the regexp feature abf3534
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@Mello21century @kevincobain2000