Add testing logics for Process.fork to avoid freezing on QEMU #497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
midnight-wonderer force-pushed the bug/test-forks-before-usage branch from 3c2ce3e to 0e0df33 Compare This was referenced Feb 14, 2025
| Only saw this now. I think it makes sense, I'd maybe write the code a bit differently though. I'll study this idea. |
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Process.forkworks correctly only once on certain QEMU/Ruby combinations, AFAIK.The detection logic is added to sidestep the issue.
See #495 for the discussion.