Updated packages and fixed the typescript compile error #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
added 9 commits November 3, 2017 13:49
…e the warning for npm install [*] tsconfig.json, Added types attribute. changed "strict" attribute to "false" since this will cause typescript compiler to throw an error about class component decorator. [*] packages, updated most of packages
…d a editor config file and make the tab indent more consistent [*] code, change " -> ' for javascript file [*] folder, move test spec files into specs folder [*] packages, updated mocha and sinon version to newest
[*] code, cleaned up code to follow the rule of eslint [*] test, moved karma.conf.js into test/unit folder. since it only used for testing
[*] packages, run eslint checking before running the test
[+] gitignore, added a ignore for package-lock.json
[+] router, separated into other folder and added hooks for components to access a callback when router-view is changing [+] vuex, added vuex-typescript supported [*] fetchdata, applied vuex-typescript into the component. [*] folders, rename css folder to static, this folder should use to contain images and css etc.
…ore. [+] vuex, added a state.ts to declare vuex store state [*] project, changed the name of vue-shim.d.ts file to typings.d.ts and moved into ClientApp folder [*] components, added a store control to the sample fetchdata component to demonstrate how to use vuex-typescript
[+] packages, added sinon-stub-promise for testing [*] packages, updated sinon version to v4.1.1 [*] fetchdata, applied async and await to dispatch action to store
Owner
| Thanks for the PR - looks interesting. One question - shouldn't the lock file be package-lock.json instead of project-lock.json? |
[+] Project/Webpack, added babel-polyfill in order to support ie 11. [*] Client/Store, changed dispatch actions to async syntax. [*] Project/Package, updated all packages. [v] Project/Eslint, fixed the settings for eslint-vue-plugin. [v] Project/Webpack, fixed the vendor js under uglifying problem. [v] Client/Components, fixed the template to allow to use vue-loader version 13.0.0+ since 13.0.0 has a breaking changes for require('comp') -> require('comp').default. 
Author
| I just followed the recommended messages under using npm install. I did not notice the npm-shrinkwrap was used for supporting older version of npm. |
…ion of npm. ;) This is a template that uses newest packages.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Most of packages has been updated and changed the configuration of typescript compiler
tsconfig.jsto remove compile errors and warnings. Now it can be run smoothly via dotnet run