Fix: add lin commit hook for css #765
Conversation
WalkthroughThis pull request introduces Stylelint configuration for CSS and SCSS linting in the project. A new Changes
Possibly related issues
Possibly related PRs
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File ( |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (3)
.pre-commit-config.yaml (1)
1-9: Enhance the pre-commit hook configurationWhile the basic setup is correct, consider these improvements for better efficiency:
- Add
types: [css,scss,sass]to optimize file filtering- Add
exclude: '^(dist|build|node_modules)/'to skip generated files- Consider adding
--fixflag to auto-fix issues when possiblerepos: - repo: local hooks: - id: stylelint name: Stylelint - entry: npx stylelint + entry: npx stylelint --fix language: node files: \.(css|scss|sass)$ + types: [css,scss,sass] + exclude: '^(dist|build|node_modules)/' additional_dependencies: ['stylelint', 'stylelint-config-standard', 'stylelint-config-standard-scss']styles/jsTokens/colors.tokens.js (2)
1-436: Remove unnecessary quotes from object propertiesESLint reports that all properties in this file are unnecessarily quoted. While the code works, it's recommended to follow the ESLint configuration and remove quotes from properties that don't require them.
Example fix for the first color:
export default { - "gray": { - "50": "var(--rad-ui-color-gray-50)", - "100": "var(--rad-ui-color-gray-100)", + gray: { + 50: "var(--rad-ui-color-gray-50)", + 100: "var(--rad-ui-color-gray-100)",Consider using a tool like
eslint --fixto automatically fix all instances.🧰 Tools
🪛 eslint
[error] 2-15: Unnecessarily quoted property 'gray' found.
(quote-props)
[error] 3-3: Unnecessarily quoted property '50' found.
(quote-props)
[error] 4-4: Unnecessarily quoted property '100' found.
(quote-props)
[error] 5-5: Unnecessarily quoted property '200' found.
(quote-props)
[error] 6-6: Unnecessarily quoted property '300' found.
(quote-props)
[error] 7-7: Unnecessarily quoted property '400' found.
(quote-props)
[error] 8-8: Unnecessarily quoted property '500' found.
(quote-props)
[error] 9-9: Unnecessarily quoted property '600' found.
(quote-props)
[error] 10-10: Unnecessarily quoted property '700' found.
(quote-props)
[error] 11-11: Unnecessarily quoted property '800' found.
(quote-props)
[error] 12-12: Unnecessarily quoted property '900' found.
(quote-props)
[error] 13-13: Unnecessarily quoted property '950' found.
(quote-props)
[error] 14-14: Unnecessarily quoted property '1000' found.
(quote-props)
[error] 16-29: Unnecessarily quoted property 'mauve' found.
(quote-props)
[error] 17-17: Unnecessarily quoted property '50' found.
(quote-props)
[error] 18-18: Unnecessarily quoted property '100' found.
(quote-props)
[error] 19-19: Unnecessarily quoted property '200' found.
(quote-props)
[error] 20-20: Unnecessarily quoted property '300' found.
(quote-props)
[error] 21-21: Unnecessarily quoted property '400' found.
(quote-props)
[error] 22-22: Unnecessarily quoted property '500' found.
(quote-props)
[error] 23-23: Unnecessarily quoted property '600' found.
(quote-props)
[error] 24-24: Unnecessarily quoted property '700' found.
(quote-props)
[error] 25-25: Unnecessarily quoted property '800' found.
(quote-props)
[error] 26-26: Unnecessarily quoted property '900' found.
(quote-props)
[error] 27-27: Unnecessarily quoted property '950' found.
(quote-props)
[error] 28-28: Unnecessarily quoted property '1000' found.
(quote-props)
[error] 30-43: Unnecessarily quoted property 'slate' found.
(quote-props)
[error] 31-31: Unnecessarily quoted property '50' found.
(quote-props)
[error] 32-32: Unnecessarily quoted property '100' found.
(quote-props)
[error] 33-33: Unnecessarily quoted property '200' found.
(quote-props)
[error] 34-34: Unnecessarily quoted property '300' found.
(quote-props)
[error] 35-35: Unnecessarily quoted property '400' found.
(quote-props)
[error] 36-36: Unnecessarily quoted property '500' found.
(quote-props)
[error] 37-37: Unnecessarily quoted property '600' found.
(quote-props)
[error] 38-38: Unnecessarily quoted property '700' found.
(quote-props)
[error] 39-39: Unnecessarily quoted property '800' found.
(quote-props)
[error] 40-40: Unnecessarily quoted property '900' found.
(quote-props)
[error] 41-41: Unnecessarily quoted property '950' found.
(quote-props)
[error] 42-42: Unnecessarily quoted property '1000' found.
(quote-props)
[error] 44-57: Unnecessarily quoted property 'sage' found.
(quote-props)
[error] 45-45: Unnecessarily quoted property '50' found.
(quote-props)
[error] 46-46: Unnecessarily quoted property '100' found.
(quote-props)
[error] 47-47: Unnecessarily quoted property '200' found.
(quote-props)
[error] 48-48: Unnecessarily quoted property '300' found.
(quote-props)
[error] 49-49: Unnecessarily quoted property '400' found.
(quote-props)
[error] 50-50: Unnecessarily quoted property '500' found.
(quote-props)
[error] 51-51: Unnecessarily quoted property '600' found.
(quote-props)
[error] 52-52: Unnecessarily quoted property '700' found.
(quote-props)
[error] 53-53: Unnecessarily quoted property '800' found.
(quote-props)
[error] 54-54: Unnecessarily quoted property '900' found.
(quote-props)
[error] 55-55: Unnecessarily quoted property '950' found.
(quote-props)
[error] 56-56: Unnecessarily quoted property '1000' found.
(quote-props)
[error] 58-71: Unnecessarily quoted property 'olive' found.
(quote-props)
[error] 59-59: Unnecessarily quoted property '50' found.
(quote-props)
[error] 60-60: Unnecessarily quoted property '100' found.
(quote-props)
[error] 61-61: Unnecessarily quoted property '200' found.
(quote-props)
[error] 62-62: Unnecessarily quoted property '300' found.
(quote-props)
[error] 63-63: Unnecessarily quoted property '400' found.
(quote-props)
[error] 64-64: Unnecessarily quoted property '500' found.
(quote-props)
[error] 65-65: Unnecessarily quoted property '600' found.
(quote-props)
[error] 66-66: Unnecessarily quoted property '700' found.
(quote-props)
[error] 67-67: Unnecessarily quoted property '800' found.
(quote-props)
[error] 68-68: Unnecessarily quoted property '900' found.
(quote-props)
[error] 69-69: Unnecessarily quoted property '950' found.
(quote-props)
[error] 70-70: Unnecessarily quoted property '1000' found.
(quote-props)
[error] 72-85: Unnecessarily quoted property 'sand' found.
(quote-props)
[error] 73-73: Unnecessarily quoted property '50' found.
(quote-props)
[error] 74-74: Unnecessarily quoted property '100' found.
(quote-props)
[error] 75-75: Unnecessarily quoted property '200' found.
(quote-props)
[error] 76-76: Unnecessarily quoted property '300' found.
(quote-props)
[error] 77-77: Unnecessarily quoted property '400' found.
(quote-props)
[error] 78-78: Unnecessarily quoted property '500' found.
(quote-props)
[error] 79-79: Unnecessarily quoted property '600' found.
(quote-props)
[error] 80-80: Unnecessarily quoted property '700' found.
(quote-props)
[error] 81-81: Unnecessarily quoted property '800' found.
(quote-props)
[error] 82-82: Unnecessarily quoted property '900' found.
(quote-props)
[error] 83-83: Unnecessarily quoted property '950' found.
(quote-props)
[error] 84-84: Unnecessarily quoted property '1000' found.
(quote-props)
[error] 86-99: Unnecessarily quoted property 'tomato' found.
(quote-props)
[error] 87-87: Unnecessarily quoted property '50' found.
(quote-props)
[error] 88-88: Unnecessarily quoted property '100' found.
(quote-props)
[error] 89-89: Unnecessarily quoted property '200' found.
(quote-props)
[error] 90-90: Unnecessarily quoted property '300' found.
(quote-props)
[error] 91-91: Unnecessarily quoted property '400' found.
(quote-props)
[error] 92-92: Unnecessarily quoted property '500' found.
(quote-props)
[error] 93-93: Unnecessarily quoted property '600' found.
(quote-props)
[error] 94-94: Unnecessarily quoted property '700' found.
(quote-props)
[error] 95-95: Unnecessarily quoted property '800' found.
(quote-props)
[error] 96-96: Unnecessarily quoted property '900' found.
(quote-props)
[error] 97-97: Unnecessarily quoted property '950' found.
(quote-props)
[error] 98-98: Unnecessarily quoted property '1000' found.
(quote-props)
[error] 100-113: Unnecessarily quoted property 'red' found.
(quote-props)
[error] 101-101: Unnecessarily quoted property '50' found.
(quote-props)
[error] 102-102: Unnecessarily quoted property '100' found.
(quote-props)
[error] 103-103: Unnecessarily quoted property '200' found.
(quote-props)
[error] 104-104: Unnecessarily quoted property '300' found.
(quote-props)
[error] 105-105: Unnecessarily quoted property '400' found.
(quote-props)
[error] 106-106: Unnecessarily quoted property '500' found.
(quote-props)
[error] 107-107: Unnecessarily quoted property '600' found.
(quote-props)
[error] 108-108: Unnecessarily quoted property '700' found.
(quote-props)
[error] 109-109: Unnecessarily quoted property '800' found.
(quote-props)
[error] 110-110: Unnecessarily quoted property '900' found.
(quote-props)
[error] 111-111: Unnecessarily quoted property '950' found.
(quote-props)
[error] 112-112: Unnecessarily quoted property '1000' found.
(quote-props)
[error] 114-127: Unnecessarily quoted property 'ruby' found.
(quote-props)
[error] 115-115: Unnecessarily quoted property '50' found.
(quote-props)
[error] 116-116: Unnecessarily quoted property '100' found.
(quote-props)
[error] 117-117: Unnecessarily quoted property '200' found.
(quote-props)
[error] 118-118: Unnecessarily quoted property '300' found.
(quote-props)
[error] 119-119: Unnecessarily quoted property '400' found.
(quote-props)
[error] 120-120: Unnecessarily quoted property '500' found.
(quote-props)
[error] 121-121: Unnecessarily quoted property '600' found.
(quote-props)
[error] 122-122: Unnecessarily quoted property '700' found.
(quote-props)
[error] 123-123: Unnecessarily quoted property '800' found.
(quote-props)
[error] 124-124: Unnecessarily quoted property '900' found.
(quote-props)
[error] 125-125: Unnecessarily quoted property '950' found.
(quote-props)
[error] 126-126: Unnecessarily quoted property '1000' found.
(quote-props)
[error] 128-141: Unnecessarily quoted property 'crimson' found.
(quote-props)
[error] 129-129: Unnecessarily quoted property '50' found.
(quote-props)
[error] 130-130: Unnecessarily quoted property '100' found.
(quote-props)
[error] 131-131: Unnecessarily quoted property '200' found.
(quote-props)
[error] 132-132: Unnecessarily quoted property '300' found.
(quote-props)
[error] 133-133: Unnecessarily quoted property '400' found.
(quote-props)
[error] 134-134: Unnecessarily quoted property '500' found.
(quote-props)
[error] 135-135: Unnecessarily quoted property '600' found.
(quote-props)
[error] 136-136: Unnecessarily quoted property '700' found.
(quote-props)
[error] 137-137: Unnecessarily quoted property '800' found.
(quote-props)
[error] 138-138: Unnecessarily quoted property '900' found.
(quote-props)
[error] 139-139: Unnecessarily quoted property '950' found.
(quote-props)
[error] 140-140: Unnecessarily quoted property '1000' found.
(quote-props)
[error] 142-155: Unnecessarily quoted property 'pink' found.
(quote-props)
[error] 143-143: Unnecessarily quoted property '50' found.
(quote-props)
[error] 144-144: Unnecessarily quoted property '100' found.
(quote-props)
[error] 145-145: Unnecessarily quoted property '200' found.
(quote-props)
[error] 146-146: Unnecessarily quoted property '300' found.
(quote-props)
[error] 147-147: Unnecessarily quoted property '400' found.
(quote-props)
[error] 148-148: Unnecessarily quoted property '500' found.
(quote-props)
[error] 149-149: Unnecessarily quoted property '600' found.
(quote-props)
[error] 150-150: Unnecessarily quoted property '700' found.
(quote-props)
[error] 151-151: Unnecessarily quoted property '800' found.
(quote-props)
[error] 152-152: Unnecessarily quoted property '900' found.
(quote-props)
[error] 153-153: Unnecessarily quoted property '950' found.
(quote-props)
[error] 154-154: Unnecessarily quoted property '1000' found.
(quote-props)
[error] 156-169: Unnecessarily quoted property 'plum' found.
(quote-props)
[error] 157-157: Unnecessarily quoted property '50' found.
(quote-props)
[error] 158-158: Unnecessarily quoted property '100' found.
(quote-props)
[error] 159-159: Unnecessarily quoted property '200' found.
(quote-props)
[error] 160-160: Unnecessarily quoted property '300' found.
(quote-props)
[error] 161-161: Unnecessarily quoted property '400' found.
(quote-props)
[error] 162-162: Unnecessarily quoted property '500' found.
(quote-props)
[error] 163-163: Unnecessarily quoted property '600' found.
(quote-props)
[error] 164-164: Unnecessarily quoted property '700' found.
(quote-props)
[error] 165-165: Unnecessarily quoted property '800' found.
(quote-props)
[error] 166-166: Unnecessarily quoted property '900' found.
(quote-props)
[error] 167-167: Unnecessarily quoted property '950' found.
(quote-props)
[error] 168-168: Unnecessarily quoted property '1000' found.
(quote-props)
[error] 170-183: Unnecessarily quoted property 'purple' found.
(quote-props)
[error] 171-171: Unnecessarily quoted property '50' found.
(quote-props)
[error] 172-172: Unnecessarily quoted property '100' found.
(quote-props)
[error] 173-173: Unnecessarily quoted property '200' found.
(quote-props)
[error] 174-174: Unnecessarily quoted property '300' found.
(quote-props)
[error] 175-175: Unnecessarily quoted property '400' found.
(quote-props)
[error] 176-176: Unnecessarily quoted property '500' found.
(quote-props)
[error] 177-177: Unnecessarily quoted property '600' found.
(quote-props)
[error] 178-178: Unnecessarily quoted property '700' found.
(quote-props)
[error] 179-179: Unnecessarily quoted property '800' found.
(quote-props)
[error] 180-180: Unnecessarily quoted property '900' found.
(quote-props)
[error] 181-181: Unnecessarily quoted property '950' found.
(quote-props)
[error] 182-182: Unnecessarily quoted property '1000' found.
(quote-props)
[error] 184-197: Unnecessarily quoted property 'violet' found.
(quote-props)
[error] 185-185: Unnecessarily quoted property '50' found.
(quote-props)
[error] 186-186: Unnecessarily quoted property '100' found.
(quote-props)
[error] 187-187: Unnecessarily quoted property '200' found.
(quote-props)
[error] 188-188: Unnecessarily quoted property '300' found.
(quote-props)
[error] 189-189: Unnecessarily quoted property '400' found.
(quote-props)
[error] 190-190: Unnecessarily quoted property '500' found.
(quote-props)
[error] 191-191: Unnecessarily quoted property '600' found.
(quote-props)
[error] 192-192: Unnecessarily quoted property '700' found.
(quote-props)
[error] 193-193: Unnecessarily quoted property '800' found.
(quote-props)
[error] 194-194: Unnecessarily quoted property '900' found.
(quote-props)
[error] 195-195: Unnecessarily quoted property '950' found.
(quote-props)
[error] 196-196: Unnecessarily quoted property '1000' found.
(quote-props)
[error] 198-211: Unnecessarily quoted property 'iris' found.
(quote-props)
[error] 199-199: Unnecessarily quoted property '50' found.
(quote-props)
[error] 200-200: Unnecessarily quoted property '100' found.
(quote-props)
[error] 201-201: Unnecessarily quoted property '200' found.
(quote-props)
[error] 202-202: Unnecessarily quoted property '300' found.
(quote-props)
[error] 203-203: Unnecessarily quoted property '400' found.
(quote-props)
[error] 204-204: Unnecessarily quoted property '500' found.
(quote-props)
[error] 205-205: Unnecessarily quoted property '600' found.
(quote-props)
[error] 206-206: Unnecessarily quoted property '700' found.
(quote-props)
[error] 207-207: Unnecessarily quoted property '800' found.
(quote-props)
[error] 208-208: Unnecessarily quoted property '900' found.
(quote-props)
[error] 209-209: Unnecessarily quoted property '950' found.
(quote-props)
[error] 210-210: Unnecessarily quoted property '1000' found.
(quote-props)
[error] 212-225: Unnecessarily quoted property 'indigo' found.
(quote-props)
[error] 213-213: Unnecessarily quoted property '50' found.
(quote-props)
[error] 214-214: Unnecessarily quoted property '100' found.
(quote-props)
[error] 215-215: Unnecessarily quoted property '200' found.
(quote-props)
[error] 216-216: Unnecessarily quoted property '300' found.
(quote-props)
[error] 217-217: Unnecessarily quoted property '400' found.
(quote-props)
[error] 218-218: Unnecessarily quoted property '500' found.
(quote-props)
[error] 219-219: Unnecessarily quoted property '600' found.
(quote-props)
[error] 220-220: Unnecessarily quoted property '700' found.
(quote-props)
[error] 221-221: Unnecessarily quoted property '800' found.
(quote-props)
[error] 222-222: Unnecessarily quoted property '900' found.
(quote-props)
[error] 223-223: Unnecessarily quoted property '950' found.
(quote-props)
[error] 224-224: Unnecessarily quoted property '1000' found.
(quote-props)
[error] 226-239: Unnecessarily quoted property 'blue' found.
(quote-props)
[error] 227-227: Unnecessarily quoted property '50' found.
(quote-props)
[error] 228-228: Unnecessarily quoted property '100' found.
(quote-props)
[error] 229-229: Unnecessarily quoted property '200' found.
(quote-props)
[error] 230-230: Unnecessarily quoted property '300' found.
(quote-props)
[error] 231-231: Unnecessarily quoted property '400' found.
(quote-props)
[error] 232-232: Unnecessarily quoted property '500' found.
(quote-props)
[error] 233-233: Unnecessarily quoted property '600' found.
(quote-props)
[error] 234-234: Unnecessarily quoted property '700' found.
(quote-props)
[error] 235-235: Unnecessarily quoted property '800' found.
(quote-props)
[error] 236-236: Unnecessarily quoted property '900' found.
(quote-props)
[error] 237-237: Unnecessarily quoted property '950' found.
(quote-props)
[error] 238-238: Unnecessarily quoted property '1000' found.
(quote-props)
[error] 240-253: Unnecessarily quoted property 'cyan' found.
(quote-props)
[error] 241-241: Unnecessarily quoted property '50' found.
(quote-props)
[error] 242-242: Unnecessarily quoted property '100' found.
(quote-props)
[error] 243-243: Unnecessarily quoted property '200' found.
(quote-props)
[error] 244-244: Unnecessarily quoted property '300' found.
(quote-props)
[error] 245-245: Unnecessarily quoted property '400' found.
(quote-props)
[error] 246-246: Unnecessarily quoted property '500' found.
(quote-props)
[error] 247-247: Unnecessarily quoted property '600' found.
(quote-props)
[error] 248-248: Unnecessarily quoted property '700' found.
(quote-props)
[error] 249-249: Unnecessarily quoted property '800' found.
(quote-props)
[error] 250-250: Unnecessarily quoted property '900' found.
(quote-props)
[error] 251-251: Unnecessarily quoted property '950' found.
(quote-props)
[error] 252-252: Unnecessarily quoted property '1000' found.
(quote-props)
[error] 254-267: Unnecessarily quoted property 'teal' found.
(quote-props)
[error] 255-255: Unnecessarily quoted property '50' found.
(quote-props)
[error] 256-256: Unnecessarily quoted property '100' found.
(quote-props)
[error] 257-257: Unnecessarily quoted property '200' found.
(quote-props)
[error] 258-258: Unnecessarily quoted property '300' found.
(quote-props)
[error] 259-259: Unnecessarily quoted property '400' found.
(quote-props)
[error] 260-260: Unnecessarily quoted property '500' found.
(quote-props)
[error] 261-261: Unnecessarily quoted property '600' found.
(quote-props)
[error] 262-262: Unnecessarily quoted property '700' found.
(quote-props)
[error] 263-263: Unnecessarily quoted property '800' found.
(quote-props)
[error] 264-264: Unnecessarily quoted property '900' found.
(quote-props)
[error] 265-265: Unnecessarily quoted property '950' found.
(quote-props)
[error] 266-266: Unnecessarily quoted property '1000' found.
(quote-props)
[error] 268-281: Unnecessarily quoted property 'jade' found.
(quote-props)
[error] 269-269: Unnecessarily quoted property '50' found.
(quote-props)
[error] 270-270: Unnecessarily quoted property '100' found.
(quote-props)
[error] 271-271: Unnecessarily quoted property '200' found.
(quote-props)
[error] 272-272: Unnecessarily quoted property '300' found.
(quote-props)
[error] 273-273: Unnecessarily quoted property '400' found.
(quote-props)
[error] 274-274: Unnecessarily quoted property '500' found.
(quote-props)
[error] 275-275: Unnecessarily quoted property '600' found.
(quote-props)
[error] 276-276: Unnecessarily quoted property '700' found.
(quote-props)
[error] 277-277: Unnecessarily quoted property '800' found.
(quote-props)
[error] 278-278: Unnecessarily quoted property '900' found.
(quote-props)
[error] 279-279: Unnecessarily quoted property '950' found.
(quote-props)
[error] 280-280: Unnecessarily quoted property '1000' found.
(quote-props)
[error] 282-295: Unnecessarily quoted property 'green' found.
(quote-props)
[error] 283-283: Unnecessarily quoted property '50' found.
(quote-props)
[error] 284-284: Unnecessarily quoted property '100' found.
(quote-props)
[error] 285-285: Unnecessarily quoted property '200' found.
(quote-props)
[error] 286-286: Unnecessarily quoted property '300' found.
(quote-props)
[error] 287-287: Unnecessarily quoted property '400' found.
(quote-props)
[error] 288-288: Unnecessarily quoted property '500' found.
(quote-props)
[error] 289-289: Unnecessarily quoted property '600' found.
(quote-props)
[error] 290-290: Unnecessarily quoted property '700' found.
(quote-props)
[error] 291-291: Unnecessarily quoted property '800' found.
(quote-props)
[error] 292-292: Unnecessarily quoted property '900' found.
(quote-props)
[error] 293-293: Unnecessarily quoted property '950' found.
(quote-props)
[error] 294-294: Unnecessarily quoted property '1000' found.
(quote-props)
[error] 296-309: Unnecessarily quoted property 'grass' found.
(quote-props)
[error] 297-297: Unnecessarily quoted property '50' found.
(quote-props)
[error] 298-298: Unnecessarily quoted property '100' found.
(quote-props)
[error] 299-299: Unnecessarily quoted property '200' found.
(quote-props)
[error] 300-300: Unnecessarily quoted property '300' found.
(quote-props)
[error] 301-301: Unnecessarily quoted property '400' found.
(quote-props)
[error] 302-302: Unnecessarily quoted property '500' found.
(quote-props)
[error] 303-303: Unnecessarily quoted property '600' found.
(quote-props)
[error] 304-304: Unnecessarily quoted property '700' found.
(quote-props)
[error] 305-305: Unnecessarily quoted property '800' found.
(quote-props)
[error] 306-306: Unnecessarily quoted property '900' found.
(quote-props)
[error] 307-307: Unnecessarily quoted property '950' found.
(quote-props)
[error] 308-308: Unnecessarily quoted property '1000' found.
(quote-props)
[error] 310-323: Unnecessarily quoted property 'brown' found.
(quote-props)
[error] 311-311: Unnecessarily quoted property '50' found.
(quote-props)
[error] 312-312: Unnecessarily quoted property '100' found.
(quote-props)
[error] 313-313: Unnecessarily quoted property '200' found.
(quote-props)
[error] 314-314: Unnecessarily quoted property '300' found.
(quote-props)
[error] 315-315: Unnecessarily quoted property '400' found.
(quote-props)
[error] 316-316: Unnecessarily quoted property '500' found.
(quote-props)
[error] 317-317: Unnecessarily quoted property '600' found.
(quote-props)
[error] 318-318: Unnecessarily quoted property '700' found.
(quote-props)
[error] 319-319: Unnecessarily quoted property '800' found.
(quote-props)
[error] 320-320: Unnecessarily quoted property '900' found.
(quote-props)
[error] 321-321: Unnecessarily quoted property '950' found.
(quote-props)
[error] 322-322: Unnecessarily quoted property '1000' found.
(quote-props)
[error] 324-337: Unnecessarily quoted property 'bronze' found.
(quote-props)
[error] 325-325: Unnecessarily quoted property '50' found.
(quote-props)
[error] 326-326: Unnecessarily quoted property '100' found.
(quote-props)
[error] 327-327: Unnecessarily quoted property '200' found.
(quote-props)
[error] 328-328: Unnecessarily quoted property '300' found.
(quote-props)
[error] 329-329: Unnecessarily quoted property '400' found.
(quote-props)
[error] 330-330: Unnecessarily quoted property '500' found.
(quote-props)
[error] 331-331: Unnecessarily quoted property '600' found.
(quote-props)
[error] 332-332: Unnecessarily quoted property '700' found.
(quote-props)
[error] 333-333: Unnecessarily quoted property '800' found.
(quote-props)
[error] 334-334: Unnecessarily quoted property '900' found.
(quote-props)
[error] 335-335: Unnecessarily quoted property '950' found.
(quote-props)
[error] 336-336: Unnecessarily quoted property '1000' found.
(quote-props)
[error] 338-351: Unnecessarily quoted property 'gold' found.
(quote-props)
[error] 339-339: Unnecessarily quoted property '50' found.
(quote-props)
[error] 340-340: Unnecessarily quoted property '100' found.
(quote-props)
[error] 341-341: Unnecessarily quoted property '200' found.
(quote-props)
[error] 342-342: Unnecessarily quoted property '300' found.
(quote-props)
[error] 343-343: Unnecessarily quoted property '400' found.
(quote-props)
[error] 344-344: Unnecessarily quoted property '500' found.
(quote-props)
[error] 345-345: Unnecessarily quoted property '600' found.
(quote-props)
[error] 346-346: Unnecessarily quoted property '700' found.
(quote-props)
[error] 347-347: Unnecessarily quoted property '800' found.
(quote-props)
[error] 348-348: Unnecessarily quoted property '900' found.
(quote-props)
[error] 349-349: Unnecessarily quoted property '950' found.
(quote-props)
[error] 350-350: Unnecessarily quoted property '1000' found.
(quote-props)
[error] 352-365: Unnecessarily quoted property 'sky' found.
(quote-props)
[error] 353-353: Unnecessarily quoted property '50' found.
(quote-props)
[error] 354-354: Unnecessarily quoted property '100' found.
(quote-props)
[error] 355-355: Unnecessarily quoted property '200' found.
(quote-props)
[error] 356-356: Unnecessarily quoted property '300' found.
(quote-props)
[error] 357-357: Unnecessarily quoted property '400' found.
(quote-props)
[error] 358-358: Unnecessarily quoted property '500' found.
(quote-props)
[error] 359-359: Unnecessarily quoted property '600' found.
(quote-props)
[error] 360-360: Unnecessarily quoted property '700' found.
(quote-props)
[error] 361-361: Unnecessarily quoted property '800' found.
(quote-props)
[error] 362-362: Unnecessarily quoted property '900' found.
(quote-props)
[error] 363-363: Unnecessarily quoted property '950' found.
(quote-props)
[error] 364-364: Unnecessarily quoted property '1000' found.
(quote-props)
[error] 366-379: Unnecessarily quoted property 'mint' found.
(quote-props)
[error] 367-367: Unnecessarily quoted property '50' found.
(quote-props)
[error] 368-368: Unnecessarily quoted property '100' found.
(quote-props)
[error] 369-369: Unnecessarily quoted property '200' found.
(quote-props)
[error] 370-370: Unnecessarily quoted property '300' found.
(quote-props)
[error] 371-371: Unnecessarily quoted property '400' found.
(quote-props)
[error] 372-372: Unnecessarily quoted property '500' found.
(quote-props)
[error] 373-373: Unnecessarily quoted property '600' found.
(quote-props)
[error] 374-374: Unnecessarily quoted property '700' found.
(quote-props)
[error] 375-375: Unnecessarily quoted property '800' found.
(quote-props)
[error] 376-376: Unnecessarily quoted property '900' found.
(quote-props)
[error] 377-377: Unnecessarily quoted property '950' found.
(quote-props)
[error] 378-378: Unnecessarily quoted property '1000' found.
(quote-props)
[error] 380-393: Unnecessarily quoted property 'lime' found.
(quote-props)
[error] 381-381: Unnecessarily quoted property '50' found.
(quote-props)
[error] 382-382: Unnecessarily quoted property '100' found.
(quote-props)
[error] 383-383: Unnecessarily quoted property '200' found.
(quote-props)
[error] 384-384: Unnecessarily quoted property '300' found.
(quote-props)
[error] 385-385: Unnecessarily quoted property '400' found.
(quote-props)
[error] 386-386: Unnecessarily quoted property '500' found.
(quote-props)
[error] 387-387: Unnecessarily quoted property '600' found.
(quote-props)
[error] 388-388: Unnecessarily quoted property '700' found.
(quote-props)
[error] 389-389: Unnecessarily quoted property '800' found.
(quote-props)
[error] 390-390: Unnecessarily quoted property '900' found.
(quote-props)
[error] 391-391: Unnecessarily quoted property '950' found.
(quote-props)
[error] 392-392: Unnecessarily quoted property '1000' found.
(quote-props)
[error] 394-407: Unnecessarily quoted property 'yellow' found.
(quote-props)
[error] 395-395: Unnecessarily quoted property '50' found.
(quote-props)
[error] 396-396: Unnecessarily quoted property '100' found.
(quote-props)
[error] 397-397: Unnecessarily quoted property '200' found.
(quote-props)
[error] 398-398: Unnecessarily quoted property '300' found.
(quote-props)
[error] 399-399: Unnecessarily quoted property '400' found.
(quote-props)
[error] 400-400: Unnecessarily quoted property '500' found.
(quote-props)
[error] 401-401: Unnecessarily quoted property '600' found.
(quote-props)
[error] 402-402: Unnecessarily quoted property '700' found.
(quote-props)
[error] 403-403: Unnecessarily quoted property '800' found.
(quote-props)
[error] 404-404: Unnecessarily quoted property '900' found.
(quote-props)
[error] 405-405: Unnecessarily quoted property '950' found.
(quote-props)
[error] 406-406: Unnecessarily quoted property '1000' found.
(quote-props)
[error] 408-421: Unnecessarily quoted property 'amber' found.
(quote-props)
[error] 409-409: Unnecessarily quoted property '50' found.
(quote-props)
[error] 410-410: Unnecessarily quoted property '100' found.
(quote-props)
[error] 411-411: Unnecessarily quoted property '200' found.
(quote-props)
[error] 412-412: Unnecessarily quoted property '300' found.
(quote-props)
[error] 413-413: Unnecessarily quoted property '400' found.
(quote-props)
[error] 414-414: Unnecessarily quoted property '500' found.
(quote-props)
[error] 415-415: Unnecessarily quoted property '600' found.
(quote-props)
[error] 416-416: Unnecessarily quoted property '700' found.
(quote-props)
[error] 417-417: Unnecessarily quoted property '800' found.
(quote-props)
[error] 418-418: Unnecessarily quoted property '900' found.
(quote-props)
[error] 419-419: Unnecessarily quoted property '950' found.
(quote-props)
[error] 420-420: Unnecessarily quoted property '1000' found.
(quote-props)
[error] 422-435: Unnecessarily quoted property 'orange' found.
(quote-props)
[error] 423-423: Unnecessarily quoted property '50' found.
(quote-props)
[error] 424-424: Unnecessarily quoted property '100' found.
(quote-props)
[error] 425-425: Unnecessarily quoted property '200' found.
(quote-props)
[error] 426-426: Unnecessarily quoted property '300' found.
(quote-props)
[error] 427-427: Unnecessarily quoted property '400' found.
(quote-props)
[error] 428-428: Unnecessarily quoted property '500' found.
(quote-props)
[error] 429-429: Unnecessarily quoted property '600' found.
(quote-props)
[error] 430-430: Unnecessarily quoted property '700' found.
(quote-props)
[error] 431-431: Unnecessarily quoted property '800' found.
(quote-props)
[error] 432-432: Unnecessarily quoted property '900' found.
(quote-props)
[error] 433-433: Unnecessarily quoted property '950' found.
(quote-props)
[error] 434-434: Unnecessarily quoted property '1000' found.
(quote-props)
[error] 436-436: Newline required at end of file but not found.
(eol-last)
436-436: Add newline at end of fileAdd a newline at the end of the file to comply with ESLint's
eol-lastrule.} -} +} +🧰 Tools
🪛 eslint
[error] 436-436: Newline required at end of file but not found.
(eol-last)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
.pre-commit-config.yaml(1 hunks).stylelintrc.json(1 hunks)package.json(2 hunks)styles/jsTokens/colors.tokens.js(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- .stylelintrc.json
🧰 Additional context used
🪛 eslint
styles/jsTokens/colors.tokens.js
[error] 2-15: Unnecessarily quoted property 'gray' found.
(quote-props)
[error] 3-3: Unnecessarily quoted property '50' found.
(quote-props)
[error] 4-4: Unnecessarily quoted property '100' found.
(quote-props)
[error] 5-5: Unnecessarily quoted property '200' found.
(quote-props)
[error] 6-6: Unnecessarily quoted property '300' found.
(quote-props)
[error] 7-7: Unnecessarily quoted property '400' found.
(quote-props)
[error] 8-8: Unnecessarily quoted property '500' found.
(quote-props)
[error] 9-9: Unnecessarily quoted property '600' found.
(quote-props)
[error] 10-10: Unnecessarily quoted property '700' found.
(quote-props)
[error] 11-11: Unnecessarily quoted property '800' found.
(quote-props)
[error] 12-12: Unnecessarily quoted property '900' found.
(quote-props)
[error] 13-13: Unnecessarily quoted property '950' found.
(quote-props)
[error] 14-14: Unnecessarily quoted property '1000' found.
(quote-props)
[error] 16-29: Unnecessarily quoted property 'mauve' found.
(quote-props)
[error] 17-17: Unnecessarily quoted property '50' found.
(quote-props)
[error] 18-18: Unnecessarily quoted property '100' found.
(quote-props)
[error] 19-19: Unnecessarily quoted property '200' found.
(quote-props)
[error] 20-20: Unnecessarily quoted property '300' found.
(quote-props)
[error] 21-21: Unnecessarily quoted property '400' found.
(quote-props)
[error] 22-22: Unnecessarily quoted property '500' found.
(quote-props)
[error] 23-23: Unnecessarily quoted property '600' found.
(quote-props)
[error] 24-24: Unnecessarily quoted property '700' found.
(quote-props)
[error] 25-25: Unnecessarily quoted property '800' found.
(quote-props)
[error] 26-26: Unnecessarily quoted property '900' found.
(quote-props)
[error] 27-27: Unnecessarily quoted property '950' found.
(quote-props)
[error] 28-28: Unnecessarily quoted property '1000' found.
(quote-props)
[error] 30-43: Unnecessarily quoted property 'slate' found.
(quote-props)
[error] 31-31: Unnecessarily quoted property '50' found.
(quote-props)
[error] 32-32: Unnecessarily quoted property '100' found.
(quote-props)
[error] 33-33: Unnecessarily quoted property '200' found.
(quote-props)
[error] 34-34: Unnecessarily quoted property '300' found.
(quote-props)
[error] 35-35: Unnecessarily quoted property '400' found.
(quote-props)
[error] 36-36: Unnecessarily quoted property '500' found.
(quote-props)
[error] 37-37: Unnecessarily quoted property '600' found.
(quote-props)
[error] 38-38: Unnecessarily quoted property '700' found.
(quote-props)
[error] 39-39: Unnecessarily quoted property '800' found.
(quote-props)
[error] 40-40: Unnecessarily quoted property '900' found.
(quote-props)
[error] 41-41: Unnecessarily quoted property '950' found.
(quote-props)
[error] 42-42: Unnecessarily quoted property '1000' found.
(quote-props)
[error] 44-57: Unnecessarily quoted property 'sage' found.
(quote-props)
[error] 45-45: Unnecessarily quoted property '50' found.
(quote-props)
[error] 46-46: Unnecessarily quoted property '100' found.
(quote-props)
[error] 47-47: Unnecessarily quoted property '200' found.
(quote-props)
[error] 48-48: Unnecessarily quoted property '300' found.
(quote-props)
[error] 49-49: Unnecessarily quoted property '400' found.
(quote-props)
[error] 50-50: Unnecessarily quoted property '500' found.
(quote-props)
[error] 51-51: Unnecessarily quoted property '600' found.
(quote-props)
[error] 52-52: Unnecessarily quoted property '700' found.
(quote-props)
[error] 53-53: Unnecessarily quoted property '800' found.
(quote-props)
[error] 54-54: Unnecessarily quoted property '900' found.
(quote-props)
[error] 55-55: Unnecessarily quoted property '950' found.
(quote-props)
[error] 56-56: Unnecessarily quoted property '1000' found.
(quote-props)
[error] 58-71: Unnecessarily quoted property 'olive' found.
(quote-props)
[error] 59-59: Unnecessarily quoted property '50' found.
(quote-props)
[error] 60-60: Unnecessarily quoted property '100' found.
(quote-props)
[error] 61-61: Unnecessarily quoted property '200' found.
(quote-props)
[error] 62-62: Unnecessarily quoted property '300' found.
(quote-props)
[error] 63-63: Unnecessarily quoted property '400' found.
(quote-props)
[error] 64-64: Unnecessarily quoted property '500' found.
(quote-props)
[error] 65-65: Unnecessarily quoted property '600' found.
(quote-props)
[error] 66-66: Unnecessarily quoted property '700' found.
(quote-props)
[error] 67-67: Unnecessarily quoted property '800' found.
(quote-props)
[error] 68-68: Unnecessarily quoted property '900' found.
(quote-props)
[error] 69-69: Unnecessarily quoted property '950' found.
(quote-props)
[error] 70-70: Unnecessarily quoted property '1000' found.
(quote-props)
[error] 72-85: Unnecessarily quoted property 'sand' found.
(quote-props)
[error] 73-73: Unnecessarily quoted property '50' found.
(quote-props)
[error] 74-74: Unnecessarily quoted property '100' found.
(quote-props)
[error] 75-75: Unnecessarily quoted property '200' found.
(quote-props)
[error] 76-76: Unnecessarily quoted property '300' found.
(quote-props)
[error] 77-77: Unnecessarily quoted property '400' found.
(quote-props)
[error] 78-78: Unnecessarily quoted property '500' found.
(quote-props)
[error] 79-79: Unnecessarily quoted property '600' found.
(quote-props)
[error] 80-80: Unnecessarily quoted property '700' found.
(quote-props)
[error] 81-81: Unnecessarily quoted property '800' found.
(quote-props)
[error] 82-82: Unnecessarily quoted property '900' found.
(quote-props)
[error] 83-83: Unnecessarily quoted property '950' found.
(quote-props)
[error] 84-84: Unnecessarily quoted property '1000' found.
(quote-props)
[error] 86-99: Unnecessarily quoted property 'tomato' found.
(quote-props)
[error] 87-87: Unnecessarily quoted property '50' found.
(quote-props)
[error] 88-88: Unnecessarily quoted property '100' found.
(quote-props)
[error] 89-89: Unnecessarily quoted property '200' found.
(quote-props)
[error] 90-90: Unnecessarily quoted property '300' found.
(quote-props)
[error] 91-91: Unnecessarily quoted property '400' found.
(quote-props)
[error] 92-92: Unnecessarily quoted property '500' found.
(quote-props)
[error] 93-93: Unnecessarily quoted property '600' found.
(quote-props)
[error] 94-94: Unnecessarily quoted property '700' found.
(quote-props)
[error] 95-95: Unnecessarily quoted property '800' found.
(quote-props)
[error] 96-96: Unnecessarily quoted property '900' found.
(quote-props)
[error] 97-97: Unnecessarily quoted property '950' found.
(quote-props)
[error] 98-98: Unnecessarily quoted property '1000' found.
(quote-props)
[error] 100-113: Unnecessarily quoted property 'red' found.
(quote-props)
[error] 101-101: Unnecessarily quoted property '50' found.
(quote-props)
[error] 102-102: Unnecessarily quoted property '100' found.
(quote-props)
[error] 103-103: Unnecessarily quoted property '200' found.
(quote-props)
[error] 104-104: Unnecessarily quoted property '300' found.
(quote-props)
[error] 105-105: Unnecessarily quoted property '400' found.
(quote-props)
[error] 106-106: Unnecessarily quoted property '500' found.
(quote-props)
[error] 107-107: Unnecessarily quoted property '600' found.
(quote-props)
[error] 108-108: Unnecessarily quoted property '700' found.
(quote-props)
[error] 109-109: Unnecessarily quoted property '800' found.
(quote-props)
[error] 110-110: Unnecessarily quoted property '900' found.
(quote-props)
[error] 111-111: Unnecessarily quoted property '950' found.
(quote-props)
[error] 112-112: Unnecessarily quoted property '1000' found.
(quote-props)
[error] 114-127: Unnecessarily quoted property 'ruby' found.
(quote-props)
[error] 115-115: Unnecessarily quoted property '50' found.
(quote-props)
[error] 116-116: Unnecessarily quoted property '100' found.
(quote-props)
[error] 117-117: Unnecessarily quoted property '200' found.
(quote-props)
[error] 118-118: Unnecessarily quoted property '300' found.
(quote-props)
[error] 119-119: Unnecessarily quoted property '400' found.
(quote-props)
[error] 120-120: Unnecessarily quoted property '500' found.
(quote-props)
[error] 121-121: Unnecessarily quoted property '600' found.
(quote-props)
[error] 122-122: Unnecessarily quoted property '700' found.
(quote-props)
[error] 123-123: Unnecessarily quoted property '800' found.
(quote-props)
[error] 124-124: Unnecessarily quoted property '900' found.
(quote-props)
[error] 125-125: Unnecessarily quoted property '950' found.
(quote-props)
[error] 126-126: Unnecessarily quoted property '1000' found.
(quote-props)
[error] 128-141: Unnecessarily quoted property 'crimson' found.
(quote-props)
[error] 129-129: Unnecessarily quoted property '50' found.
(quote-props)
[error] 130-130: Unnecessarily quoted property '100' found.
(quote-props)
[error] 131-131: Unnecessarily quoted property '200' found.
(quote-props)
[error] 132-132: Unnecessarily quoted property '300' found.
(quote-props)
[error] 133-133: Unnecessarily quoted property '400' found.
(quote-props)
[error] 134-134: Unnecessarily quoted property '500' found.
(quote-props)
[error] 135-135: Unnecessarily quoted property '600' found.
(quote-props)
[error] 136-136: Unnecessarily quoted property '700' found.
(quote-props)
[error] 137-137: Unnecessarily quoted property '800' found.
(quote-props)
[error] 138-138: Unnecessarily quoted property '900' found.
(quote-props)
[error] 139-139: Unnecessarily quoted property '950' found.
(quote-props)
[error] 140-140: Unnecessarily quoted property '1000' found.
(quote-props)
[error] 142-155: Unnecessarily quoted property 'pink' found.
(quote-props)
[error] 143-143: Unnecessarily quoted property '50' found.
(quote-props)
[error] 144-144: Unnecessarily quoted property '100' found.
(quote-props)
[error] 145-145: Unnecessarily quoted property '200' found.
(quote-props)
[error] 146-146: Unnecessarily quoted property '300' found.
(quote-props)
[error] 147-147: Unnecessarily quoted property '400' found.
(quote-props)
[error] 148-148: Unnecessarily quoted property '500' found.
(quote-props)
[error] 149-149: Unnecessarily quoted property '600' found.
(quote-props)
[error] 150-150: Unnecessarily quoted property '700' found.
(quote-props)
[error] 151-151: Unnecessarily quoted property '800' found.
(quote-props)
[error] 152-152: Unnecessarily quoted property '900' found.
(quote-props)
[error] 153-153: Unnecessarily quoted property '950' found.
(quote-props)
[error] 154-154: Unnecessarily quoted property '1000' found.
(quote-props)
[error] 156-169: Unnecessarily quoted property 'plum' found.
(quote-props)
[error] 157-157: Unnecessarily quoted property '50' found.
(quote-props)
[error] 158-158: Unnecessarily quoted property '100' found.
(quote-props)
[error] 159-159: Unnecessarily quoted property '200' found.
(quote-props)
[error] 160-160: Unnecessarily quoted property '300' found.
(quote-props)
[error] 161-161: Unnecessarily quoted property '400' found.
(quote-props)
[error] 162-162: Unnecessarily quoted property '500' found.
(quote-props)
[error] 163-163: Unnecessarily quoted property '600' found.
(quote-props)
[error] 164-164: Unnecessarily quoted property '700' found.
(quote-props)
[error] 165-165: Unnecessarily quoted property '800' found.
(quote-props)
[error] 166-166: Unnecessarily quoted property '900' found.
(quote-props)
[error] 167-167: Unnecessarily quoted property '950' found.
(quote-props)
[error] 168-168: Unnecessarily quoted property '1000' found.
(quote-props)
[error] 170-183: Unnecessarily quoted property 'purple' found.
(quote-props)
[error] 171-171: Unnecessarily quoted property '50' found.
(quote-props)
[error] 172-172: Unnecessarily quoted property '100' found.
(quote-props)
[error] 173-173: Unnecessarily quoted property '200' found.
(quote-props)
[error] 174-174: Unnecessarily quoted property '300' found.
(quote-props)
[error] 175-175: Unnecessarily quoted property '400' found.
(quote-props)
[error] 176-176: Unnecessarily quoted property '500' found.
(quote-props)
[error] 177-177: Unnecessarily quoted property '600' found.
(quote-props)
[error] 178-178: Unnecessarily quoted property '700' found.
(quote-props)
[error] 179-179: Unnecessarily quoted property '800' found.
(quote-props)
[error] 180-180: Unnecessarily quoted property '900' found.
(quote-props)
[error] 181-181: Unnecessarily quoted property '950' found.
(quote-props)
[error] 182-182: Unnecessarily quoted property '1000' found.
(quote-props)
[error] 184-197: Unnecessarily quoted property 'violet' found.
(quote-props)
[error] 185-185: Unnecessarily quoted property '50' found.
(quote-props)
[error] 186-186: Unnecessarily quoted property '100' found.
(quote-props)
[error] 187-187: Unnecessarily quoted property '200' found.
(quote-props)
[error] 188-188: Unnecessarily quoted property '300' found.
(quote-props)
[error] 189-189: Unnecessarily quoted property '400' found.
(quote-props)
[error] 190-190: Unnecessarily quoted property '500' found.
(quote-props)
[error] 191-191: Unnecessarily quoted property '600' found.
(quote-props)
[error] 192-192: Unnecessarily quoted property '700' found.
(quote-props)
[error] 193-193: Unnecessarily quoted property '800' found.
(quote-props)
[error] 194-194: Unnecessarily quoted property '900' found.
(quote-props)
[error] 195-195: Unnecessarily quoted property '950' found.
(quote-props)
[error] 196-196: Unnecessarily quoted property '1000' found.
(quote-props)
[error] 198-211: Unnecessarily quoted property 'iris' found.
(quote-props)
[error] 199-199: Unnecessarily quoted property '50' found.
(quote-props)
[error] 200-200: Unnecessarily quoted property '100' found.
(quote-props)
[error] 201-201: Unnecessarily quoted property '200' found.
(quote-props)
[error] 202-202: Unnecessarily quoted property '300' found.
(quote-props)
[error] 203-203: Unnecessarily quoted property '400' found.
(quote-props)
[error] 204-204: Unnecessarily quoted property '500' found.
(quote-props)
[error] 205-205: Unnecessarily quoted property '600' found.
(quote-props)
[error] 206-206: Unnecessarily quoted property '700' found.
(quote-props)
[error] 207-207: Unnecessarily quoted property '800' found.
(quote-props)
[error] 208-208: Unnecessarily quoted property '900' found.
(quote-props)
[error] 209-209: Unnecessarily quoted property '950' found.
(quote-props)
[error] 210-210: Unnecessarily quoted property '1000' found.
(quote-props)
[error] 212-225: Unnecessarily quoted property 'indigo' found.
(quote-props)
[error] 213-213: Unnecessarily quoted property '50' found.
(quote-props)
[error] 214-214: Unnecessarily quoted property '100' found.
(quote-props)
[error] 215-215: Unnecessarily quoted property '200' found.
(quote-props)
[error] 216-216: Unnecessarily quoted property '300' found.
(quote-props)
[error] 217-217: Unnecessarily quoted property '400' found.
(quote-props)
[error] 218-218: Unnecessarily quoted property '500' found.
(quote-props)
[error] 219-219: Unnecessarily quoted property '600' found.
(quote-props)
[error] 220-220: Unnecessarily quoted property '700' found.
(quote-props)
[error] 221-221: Unnecessarily quoted property '800' found.
(quote-props)
[error] 222-222: Unnecessarily quoted property '900' found.
(quote-props)
[error] 223-223: Unnecessarily quoted property '950' found.
(quote-props)
[error] 224-224: Unnecessarily quoted property '1000' found.
(quote-props)
[error] 226-239: Unnecessarily quoted property 'blue' found.
(quote-props)
[error] 227-227: Unnecessarily quoted property '50' found.
(quote-props)
[error] 228-228: Unnecessarily quoted property '100' found.
(quote-props)
[error] 229-229: Unnecessarily quoted property '200' found.
(quote-props)
[error] 230-230: Unnecessarily quoted property '300' found.
(quote-props)
[error] 231-231: Unnecessarily quoted property '400' found.
(quote-props)
[error] 232-232: Unnecessarily quoted property '500' found.
(quote-props)
[error] 233-233: Unnecessarily quoted property '600' found.
(quote-props)
[error] 234-234: Unnecessarily quoted property '700' found.
(quote-props)
[error] 235-235: Unnecessarily quoted property '800' found.
(quote-props)
[error] 236-236: Unnecessarily quoted property '900' found.
(quote-props)
[error] 237-237: Unnecessarily quoted property '950' found.
(quote-props)
[error] 238-238: Unnecessarily quoted property '1000' found.
(quote-props)
[error] 240-253: Unnecessarily quoted property 'cyan' found.
(quote-props)
[error] 241-241: Unnecessarily quoted property '50' found.
(quote-props)
[error] 242-242: Unnecessarily quoted property '100' found.
(quote-props)
[error] 243-243: Unnecessarily quoted property '200' found.
(quote-props)
[error] 244-244: Unnecessarily quoted property '300' found.
(quote-props)
[error] 245-245: Unnecessarily quoted property '400' found.
(quote-props)
[error] 246-246: Unnecessarily quoted property '500' found.
(quote-props)
[error] 247-247: Unnecessarily quoted property '600' found.
(quote-props)
[error] 248-248: Unnecessarily quoted property '700' found.
(quote-props)
[error] 249-249: Unnecessarily quoted property '800' found.
(quote-props)
[error] 250-250: Unnecessarily quoted property '900' found.
(quote-props)
[error] 251-251: Unnecessarily quoted property '950' found.
(quote-props)
[error] 252-252: Unnecessarily quoted property '1000' found.
(quote-props)
[error] 254-267: Unnecessarily quoted property 'teal' found.
(quote-props)
[error] 255-255: Unnecessarily quoted property '50' found.
(quote-props)
[error] 256-256: Unnecessarily quoted property '100' found.
(quote-props)
[error] 257-257: Unnecessarily quoted property '200' found.
(quote-props)
[error] 258-258: Unnecessarily quoted property '300' found.
(quote-props)
[error] 259-259: Unnecessarily quoted property '400' found.
(quote-props)
[error] 260-260: Unnecessarily quoted property '500' found.
(quote-props)
[error] 261-261: Unnecessarily quoted property '600' found.
(quote-props)
[error] 262-262: Unnecessarily quoted property '700' found.
(quote-props)
[error] 263-263: Unnecessarily quoted property '800' found.
(quote-props)
[error] 264-264: Unnecessarily quoted property '900' found.
(quote-props)
[error] 265-265: Unnecessarily quoted property '950' found.
(quote-props)
[error] 266-266: Unnecessarily quoted property '1000' found.
(quote-props)
[error] 268-281: Unnecessarily quoted property 'jade' found.
(quote-props)
[error] 269-269: Unnecessarily quoted property '50' found.
(quote-props)
[error] 270-270: Unnecessarily quoted property '100' found.
(quote-props)
[error] 271-271: Unnecessarily quoted property '200' found.
(quote-props)
[error] 272-272: Unnecessarily quoted property '300' found.
(quote-props)
[error] 273-273: Unnecessarily quoted property '400' found.
(quote-props)
[error] 274-274: Unnecessarily quoted property '500' found.
(quote-props)
[error] 275-275: Unnecessarily quoted property '600' found.
(quote-props)
[error] 276-276: Unnecessarily quoted property '700' found.
(quote-props)
[error] 277-277: Unnecessarily quoted property '800' found.
(quote-props)
[error] 278-278: Unnecessarily quoted property '900' found.
(quote-props)
[error] 279-279: Unnecessarily quoted property '950' found.
(quote-props)
[error] 280-280: Unnecessarily quoted property '1000' found.
(quote-props)
[error] 282-295: Unnecessarily quoted property 'green' found.
(quote-props)
[error] 283-283: Unnecessarily quoted property '50' found.
(quote-props)
[error] 284-284: Unnecessarily quoted property '100' found.
(quote-props)
[error] 285-285: Unnecessarily quoted property '200' found.
(quote-props)
[error] 286-286: Unnecessarily quoted property '300' found.
(quote-props)
[error] 287-287: Unnecessarily quoted property '400' found.
(quote-props)
[error] 288-288: Unnecessarily quoted property '500' found.
(quote-props)
[error] 289-289: Unnecessarily quoted property '600' found.
(quote-props)
[error] 290-290: Unnecessarily quoted property '700' found.
(quote-props)
[error] 291-291: Unnecessarily quoted property '800' found.
(quote-props)
[error] 292-292: Unnecessarily quoted property '900' found.
(quote-props)
[error] 293-293: Unnecessarily quoted property '950' found.
(quote-props)
[error] 294-294: Unnecessarily quoted property '1000' found.
(quote-props)
[error] 296-309: Unnecessarily quoted property 'grass' found.
(quote-props)
[error] 297-297: Unnecessarily quoted property '50' found.
(quote-props)
[error] 298-298: Unnecessarily quoted property '100' found.
(quote-props)
[error] 299-299: Unnecessarily quoted property '200' found.
(quote-props)
[error] 300-300: Unnecessarily quoted property '300' found.
(quote-props)
[error] 301-301: Unnecessarily quoted property '400' found.
(quote-props)
[error] 302-302: Unnecessarily quoted property '500' found.
(quote-props)
[error] 303-303: Unnecessarily quoted property '600' found.
(quote-props)
[error] 304-304: Unnecessarily quoted property '700' found.
(quote-props)
[error] 305-305: Unnecessarily quoted property '800' found.
(quote-props)
[error] 306-306: Unnecessarily quoted property '900' found.
(quote-props)
[error] 307-307: Unnecessarily quoted property '950' found.
(quote-props)
[error] 308-308: Unnecessarily quoted property '1000' found.
(quote-props)
[error] 310-323: Unnecessarily quoted property 'brown' found.
(quote-props)
[error] 311-311: Unnecessarily quoted property '50' found.
(quote-props)
[error] 312-312: Unnecessarily quoted property '100' found.
(quote-props)
[error] 313-313: Unnecessarily quoted property '200' found.
(quote-props)
[error] 314-314: Unnecessarily quoted property '300' found.
(quote-props)
[error] 315-315: Unnecessarily quoted property '400' found.
(quote-props)
[error] 316-316: Unnecessarily quoted property '500' found.
(quote-props)
[error] 317-317: Unnecessarily quoted property '600' found.
(quote-props)
[error] 318-318: Unnecessarily quoted property '700' found.
(quote-props)
[error] 319-319: Unnecessarily quoted property '800' found.
(quote-props)
[error] 320-320: Unnecessarily quoted property '900' found.
(quote-props)
[error] 321-321: Unnecessarily quoted property '950' found.
(quote-props)
[error] 322-322: Unnecessarily quoted property '1000' found.
(quote-props)
[error] 324-337: Unnecessarily quoted property 'bronze' found.
(quote-props)
[error] 325-325: Unnecessarily quoted property '50' found.
(quote-props)
[error] 326-326: Unnecessarily quoted property '100' found.
(quote-props)
[error] 327-327: Unnecessarily quoted property '200' found.
(quote-props)
[error] 328-328: Unnecessarily quoted property '300' found.
(quote-props)
[error] 329-329: Unnecessarily quoted property '400' found.
(quote-props)
[error] 330-330: Unnecessarily quoted property '500' found.
(quote-props)
[error] 331-331: Unnecessarily quoted property '600' found.
(quote-props)
[error] 332-332: Unnecessarily quoted property '700' found.
(quote-props)
[error] 333-333: Unnecessarily quoted property '800' found.
(quote-props)
[error] 334-334: Unnecessarily quoted property '900' found.
(quote-props)
[error] 335-335: Unnecessarily quoted property '950' found.
(quote-props)
[error] 336-336: Unnecessarily quoted property '1000' found.
(quote-props)
[error] 338-351: Unnecessarily quoted property 'gold' found.
(quote-props)
[error] 339-339: Unnecessarily quoted property '50' found.
(quote-props)
[error] 340-340: Unnecessarily quoted property '100' found.
(quote-props)
[error] 341-341: Unnecessarily quoted property '200' found.
(quote-props)
[error] 342-342: Unnecessarily quoted property '300' found.
(quote-props)
[error] 343-343: Unnecessarily quoted property '400' found.
(quote-props)
[error] 344-344: Unnecessarily quoted property '500' found.
(quote-props)
[error] 345-345: Unnecessarily quoted property '600' found.
(quote-props)
[error] 346-346: Unnecessarily quoted property '700' found.
(quote-props)
[error] 347-347: Unnecessarily quoted property '800' found.
(quote-props)
[error] 348-348: Unnecessarily quoted property '900' found.
(quote-props)
[error] 349-349: Unnecessarily quoted property '950' found.
(quote-props)
[error] 350-350: Unnecessarily quoted property '1000' found.
(quote-props)
[error] 352-365: Unnecessarily quoted property 'sky' found.
(quote-props)
[error] 353-353: Unnecessarily quoted property '50' found.
(quote-props)
[error] 354-354: Unnecessarily quoted property '100' found.
(quote-props)
[error] 355-355: Unnecessarily quoted property '200' found.
(quote-props)
[error] 356-356: Unnecessarily quoted property '300' found.
(quote-props)
[error] 357-357: Unnecessarily quoted property '400' found.
(quote-props)
[error] 358-358: Unnecessarily quoted property '500' found.
(quote-props)
[error] 359-359: Unnecessarily quoted property '600' found.
(quote-props)
[error] 360-360: Unnecessarily quoted property '700' found.
(quote-props)
[error] 361-361: Unnecessarily quoted property '800' found.
(quote-props)
[error] 362-362: Unnecessarily quoted property '900' found.
(quote-props)
[error] 363-363: Unnecessarily quoted property '950' found.
(quote-props)
[error] 364-364: Unnecessarily quoted property '1000' found.
(quote-props)
[error] 366-379: Unnecessarily quoted property 'mint' found.
(quote-props)
[error] 367-367: Unnecessarily quoted property '50' found.
(quote-props)
[error] 368-368: Unnecessarily quoted property '100' found.
(quote-props)
[error] 369-369: Unnecessarily quoted property '200' found.
(quote-props)
[error] 370-370: Unnecessarily quoted property '300' found.
(quote-props)
[error] 371-371: Unnecessarily quoted property '400' found.
(quote-props)
[error] 372-372: Unnecessarily quoted property '500' found.
(quote-props)
[error] 373-373: Unnecessarily quoted property '600' found.
(quote-props)
[error] 374-374: Unnecessarily quoted property '700' found.
(quote-props)
[error] 375-375: Unnecessarily quoted property '800' found.
(quote-props)
[error] 376-376: Unnecessarily quoted property '900' found.
(quote-props)
[error] 377-377: Unnecessarily quoted property '950' found.
(quote-props)
[error] 378-378: Unnecessarily quoted property '1000' found.
(quote-props)
[error] 380-393: Unnecessarily quoted property 'lime' found.
(quote-props)
[error] 381-381: Unnecessarily quoted property '50' found.
(quote-props)
[error] 382-382: Unnecessarily quoted property '100' found.
(quote-props)
[error] 383-383: Unnecessarily quoted property '200' found.
(quote-props)
[error] 384-384: Unnecessarily quoted property '300' found.
(quote-props)
[error] 385-385: Unnecessarily quoted property '400' found.
(quote-props)
[error] 386-386: Unnecessarily quoted property '500' found.
(quote-props)
[error] 387-387: Unnecessarily quoted property '600' found.
(quote-props)
[error] 388-388: Unnecessarily quoted property '700' found.
(quote-props)
[error] 389-389: Unnecessarily quoted property '800' found.
(quote-props)
[error] 390-390: Unnecessarily quoted property '900' found.
(quote-props)
[error] 391-391: Unnecessarily quoted property '950' found.
(quote-props)
[error] 392-392: Unnecessarily quoted property '1000' found.
(quote-props)
[error] 394-407: Unnecessarily quoted property 'yellow' found.
(quote-props)
[error] 395-395: Unnecessarily quoted property '50' found.
(quote-props)
[error] 396-396: Unnecessarily quoted property '100' found.
(quote-props)
[error] 397-397: Unnecessarily quoted property '200' found.
(quote-props)
[error] 398-398: Unnecessarily quoted property '300' found.
(quote-props)
[error] 399-399: Unnecessarily quoted property '400' found.
(quote-props)
[error] 400-400: Unnecessarily quoted property '500' found.
(quote-props)
[error] 401-401: Unnecessarily quoted property '600' found.
(quote-props)
[error] 402-402: Unnecessarily quoted property '700' found.
(quote-props)
[error] 403-403: Unnecessarily quoted property '800' found.
(quote-props)
[error] 404-404: Unnecessarily quoted property '900' found.
(quote-props)
[error] 405-405: Unnecessarily quoted property '950' found.
(quote-props)
[error] 406-406: Unnecessarily quoted property '1000' found.
(quote-props)
[error] 408-421: Unnecessarily quoted property 'amber' found.
(quote-props)
[error] 409-409: Unnecessarily quoted property '50' found.
(quote-props)
[error] 410-410: Unnecessarily quoted property '100' found.
(quote-props)
[error] 411-411: Unnecessarily quoted property '200' found.
(quote-props)
[error] 412-412: Unnecessarily quoted property '300' found.
(quote-props)
[error] 413-413: Unnecessarily quoted property '400' found.
(quote-props)
[error] 414-414: Unnecessarily quoted property '500' found.
(quote-props)
[error] 415-415: Unnecessarily quoted property '600' found.
(quote-props)
[error] 416-416: Unnecessarily quoted property '700' found.
(quote-props)
[error] 417-417: Unnecessarily quoted property '800' found.
(quote-props)
[error] 418-418: Unnecessarily quoted property '900' found.
(quote-props)
[error] 419-419: Unnecessarily quoted property '950' found.
(quote-props)
[error] 420-420: Unnecessarily quoted property '1000' found.
(quote-props)
[error] 422-435: Unnecessarily quoted property 'orange' found.
(quote-props)
[error] 423-423: Unnecessarily quoted property '50' found.
(quote-props)
[error] 424-424: Unnecessarily quoted property '100' found.
(quote-props)
[error] 425-425: Unnecessarily quoted property '200' found.
(quote-props)
[error] 426-426: Unnecessarily quoted property '300' found.
(quote-props)
[error] 427-427: Unnecessarily quoted property '400' found.
(quote-props)
[error] 428-428: Unnecessarily quoted property '500' found.
(quote-props)
[error] 429-429: Unnecessarily quoted property '600' found.
(quote-props)
[error] 430-430: Unnecessarily quoted property '700' found.
(quote-props)
[error] 431-431: Unnecessarily quoted property '800' found.
(quote-props)
[error] 432-432: Unnecessarily quoted property '900' found.
(quote-props)
[error] 433-433: Unnecessarily quoted property '950' found.
(quote-props)
[error] 434-434: Unnecessarily quoted property '1000' found.
(quote-props)
[error] 436-436: Newline required at end of file but not found.
(eol-last)
🔇 Additional comments (1)
package.json (1)
128-130: LGTM! Dependencies are up to dateThe Stylelint-related dependencies are using the latest stable versions.
package.json Outdated
| "jest-environment-jsdom": "29.7.0", | ||
| "mkdirp": "^3.0.1", | ||
| "postcss": "8.4.49", | ||
| "pre-commit": "^1.2.2", |
There was a problem hiding this comment.
Remove redundant pre-commit package
The project already uses husky for managing git hooks. Adding the pre-commit package could lead to conflicts or confusion. Consider removing it and implementing the Stylelint check through husky instead.
- "pre-commit": "^1.2.2",Add the Stylelint check to your husky pre-commit hook configuration instead.
There was a problem hiding this comment.
i remove that package
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (1)
package.json (1)
127-129: Consider using fixed versions for stylelint packagesUsing caret ranges (
^) for stylelint and its configurations could lead to breaking changes in future updates.Lock the versions to ensure consistent behavior:
-"stylelint": "^16.12.0", -"stylelint-config-standard": "^36.0.1", -"stylelint-config-standard-scss": "^14.0.0", +"stylelint": "16.12.0", +"stylelint-config-standard": "36.0.1", +"stylelint-config-standard-scss": "14.0.0",
.husky/pre-commit Outdated
| npm run lint | ||
| npx stylelint "**/*.{css,scss,sass}" --fix |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Remove redundant stylelint execution
The stylelint check is already included in the lint script. Running it again separately is redundant and may impact commit performance.
Apply this diff to remove the duplicate check:
npm run lint -npx stylelint "**/*.{css,scss,sass}" --fix📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| npm run lint | |
| npx stylelint "**/*.{css,scss,sass}" --fix | |
| npm run lint |
There was a problem hiding this comment.
i remove this duplicate stylelint
package.json Outdated
| "build": "npm run prebuild && npm run build:css && NODE_OPTIONS='--max-old-space-size=4076' npm run build:components", | ||
| "release": "npm publish --access public", | ||
| "lint": "eslint --ext .js,.jsx,.ts,.tsx . --fix", | ||
| "lint": "eslint --ext .js,.jsx,.ts,.tsx . --fix && stylelint \"**/*.{css,scss,sass}\" --fix", |
There was a problem hiding this comment.
Add stylelint configuration file
The lint script has been updated to use stylelint, but the configuration file .stylelintrc.json is missing. This is required for stylelint to work properly.
Create a .stylelintrc.json file with appropriate rules for SCSS and TailwindCSS:
{ "extends": [ "stylelint-config-standard", "stylelint-config-standard-scss" ], "rules": { "at-rule-no-unknown": null, "scss/at-rule-no-unknown": [ true, { "ignoreAtRules": [ "tailwind", "apply", "variants", "responsive", "screen" ] } ] } }There was a problem hiding this comment.
this has been already added
There was a problem hiding this comment.
@js199069 I apologize for the oversight. You're absolutely right - not only was .stylelintrc.json already added, but your configuration is more comprehensive than what I suggested, with proper handling of both SCSS and Tailwind CSS rules. Thank you for the correction.
(｡•́︿•̀｡)
🔗 Analysis chain
@js199069 I apologize for the oversight. You're absolutely right - I can see that .stylelintrc.json was already added in this PR. Thank you for the correction.
(｡•́︿•̀｡)
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check if .stylelintrc.json exists and show its content cat .stylelintrc.json Length of output: 589
| "stylelint": "^16.12.0", | ||
| "stylelint-config-standard": "^36.0.1", | ||
| "stylelint-config-standard-scss": "^14.0.0", |
There was a problem hiding this comment.
Add missing peer dependencies and TailwindCSS integration
The current setup is missing some essential dependencies:
stylelint-scssis required bystylelint-config-standard-scssstylelint-config-tailwindcssis needed for proper TailwindCSS integration
Add the following dependencies:
"stylelint": "^16.12.0", "stylelint-config-standard": "^36.0.1", "stylelint-config-standard-scss": "^14.0.0", +"stylelint-scss": "^6.0.0", +"stylelint-config-tailwindcss": "^0.1.0",Then update the .stylelintrc.json configuration to include TailwindCSS:
{ "extends": [ "stylelint-config-standard", - "stylelint-config-standard-scss" + "stylelint-config-standard-scss", + "stylelint-config-tailwindcss" ], ... }Committable suggestion skipped: line range outside the PR's diff.
There was a problem hiding this comment.
these packages add now
There was a problem hiding this comment.
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (3)
.stylelintrc.json (3)
20-20: Consider a more targeted approach to handling specificity.While disabling
no-descending-specificityis common with Tailwind CSS, consider using a more targeted approach to maintain CSS best practices in your custom styles:
- Use
/* stylelint-disable-next-line no-descending-specificity */comments for specific Tailwind-generated cases- Keep the rule enabled globally to catch potential issues in custom CSS
21-32: Consider adding SCSS-specific at-rules to the ignore list.While the current configuration correctly handles Tailwind directives, consider adding common SCSS-specific at-rules to the ignore list:
"scss/at-rule-no-unknown": [ true, { "ignoreAtRules": [ "tailwind", "apply", "variants", "responsive", "screen", + "use", + "forward", + "function", + "extend" ] } ]
7-33: Consider adding project-specific rules.To maintain consistency across the project, consider adding these commonly used rules:
"rules": { + "custom-property-pattern": "^[a-z][a-zA-Z0-9]+$", + "selector-class-pattern": "^[a-z][a-zA-Z0-9]+$", + "max-nesting-depth": 3, + "declaration-no-important": true, // ... existing rules ... }These rules will help:
- Enforce consistent naming for custom properties and classes
- Prevent excessive nesting
- Discourage the use of
!important
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.stylelintrc.json(1 hunks)package.json(2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- package.json
🔇 Additional comments (1)
.stylelintrc.json (1)
2-6: LGTM! Appropriate base configurations are extended.The configuration extends the necessary preset configurations for standard CSS, SCSS, and Tailwind CSS compatibility, which aligns well with the project's tech stack (Next.js with SASS and TailwindCSS).
.stylelintrc.json Outdated
| "at-rule-no-unknown": [ | ||
| true, | ||
| { | ||
| "ignoreAtRules": [ | ||
| "tailwind", | ||
| "apply", | ||
| "variants", | ||
| "responsive", | ||
| "screen" | ||
| ] | ||
| } | ||
| ], |
There was a problem hiding this comment.
💡 Codebase verification
Remove redundant at-rule-no-unknown configuration
The configuration is redundant as stylelint-config-tailwindcss already includes these rules with even better coverage. The preset handles all your ignored rules plus additional ones like layer and config. You can safely remove this configuration and rely on the preset.
🔗 Analysis chain
Verify if this configuration is necessary.
While the configuration is correct, it might be redundant since you're already extending stylelint-config-tailwindcss which should handle these Tailwind-specific at-rules.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check if stylelint-config-tailwindcss already includes these rules curl -s https://registry.npmjs.org/stylelint-config-tailwindcss/latest | jq -r '.dist.tarball' | xargs curl -s | tar -xzO package/index.js | grep -A 10 "at-rule-no-unknown" Length of output: 405
There was a problem hiding this comment.
@js199069 I notice that while you removed the at-rule-no-unknown configuration, there's still a similar redundant configuration under scss/at-rule-no-unknown. This can also be safely removed as it's already handled by stylelint-config-tailwindcss. The configuration can be simplified to just:
{ "extends": [ "stylelint-config-standard", "stylelint-config-standard-scss", "stylelint-config-tailwindcss" ], "rules": { "no-descending-specificity": null } }(\ /)
(o.o) <♪ Just noticed one more thing to simplify!
🔗 Analysis chain
@js199069 Perfect! The redundant configuration has been removed, making the setup cleaner while maintaining the same functionality through the Tailwind preset.
(\ /)
(^.^) <♥ Thank you for the fix!
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check if the redundant configuration has been removed from .stylelintrc.json cat .stylelintrc.json Length of output: 419
If you found this review helpful, would you consider giving us a shout-out on X?
Thank you for using CodeRabbit!
There was a problem hiding this comment.
this redundant also removed
There was a problem hiding this comment.
@js199069 I notice that scss/at-rule-no-unknown is still present in the configuration but set to null. While this effectively disables the rule, we can make the configuration even cleaner by removing this line entirely. Here's the suggested minimal configuration:
{ "extends": [ "stylelint-config-standard", "stylelint-config-standard-scss", "stylelint-config-tailwindcss" ], "rules": { "no-descending-specificity": null } }This achieves the same result with less configuration. Would you like to remove this line to keep the configuration minimal?
🔗 Analysis chain
@js199069 Perfect! The configuration is now clean and optimized. Both redundant rules have been removed while maintaining the same functionality through the presets.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check the current content of .stylelintrc.json cat .stylelintrc.json Length of output: 245
kotAPI added the automerge 
| It seems like there are issues with the CI @js199069 you can take a look at those and resolve them, let me know if you need any assistance, would be glad to help! |
| @kotAPI |
Try deleting the package.lock.json Run npm install - this should resolve the dependencies |
| package.lock.json delete |
| Ready for review? @js199069 Btw we have a Discord too if you're interested in joining! |
| @kotAPI |
| Seems like your changes are working too well, lol! |
| i myself prevent to push updated file as lint fixes so many files. i will lint it and push it |
Let me know how many files we have to change, if its too big we can push the lint files in chunks in smaller prs and merge this pr at the end |
| @kotAPI |
| @kotAPI |
Can we configure to treat these as warnings or turn them off? We can probably fix this at a later stage |
| @kotAPI |
…js199069/fix-issue-471
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (2)
.stylelintrc.json(1 hunks)package.json(2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- package.json
🔇 Additional comments (2)
.stylelintrc.json (2)
9-9: Document the reason for disabling no-descending-specificity.The
no-descending-specificityrule is disabled without explanation. This rule helps prevent specificity-related conflicts in CSS. Please add a comment explaining why this rule needs to be disabled, or consider enabling it if there's no specific reason to disable it.
10-10: Remove redundant scss/at-rule-no-unknown configuration.The
scss/at-rule-no-unknownrule configuration is redundant as it's already handled bystylelint-config-tailwindcss. You can safely remove this line to keep the configuration minimal while maintaining the same functionality.{ "extends": [ "stylelint-config-standard", "stylelint-config-standard-scss", "stylelint-config-tailwindcss" ], "defaultSeverity": "warning", "rules": { - "no-descending-specificity": null, - "scss/at-rule-no-unknown": null + "no-descending-specificity": null } }
| "stylelint-config-standard-scss", | ||
| "stylelint-config-tailwindcss" | ||
| ], | ||
| "defaultSeverity": "warning", |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Consider using "error" severity for pre-commit hooks.
Setting defaultSeverity to "warning" might be too lenient for a pre-commit hook, as it will allow commits even when style issues are detected. Consider changing it to "error" to ensure style consistency is enforced.
- "defaultSeverity": "warning", + "defaultSeverity": "error",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "defaultSeverity": "warning", | |
| "defaultSeverity": "error", |
There was a problem hiding this comment.
this line assume errors as warnings
"defaultSeverity": "warning",
There was a problem hiding this comment.
@js199069 I understand your approach. Setting the severity to "warning" is indeed a good strategy during the initial adoption phase, allowing the team to gradually address the style issues while maintaining development velocity.
⟪ ◕ᴗ◕ ⟫
∫∫∫
✏️ Learnings added
Learnt from: js199069 PR: rad-ui/ui#765 File: .stylelintrc.json:7-7 Timestamp: 2025-01-13T18:10:34.853Z Learning: In Stylelint configuration, setting `defaultSeverity` to "warning" is preferred during the initial setup phase to allow gradual adoption of style rules, especially when there are existing style issues to be addressed over time. Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.
| @kotAPI "**/*.{css,scss,sass}" --no-fix |
3 participants
Fixing the Set Up CSS linting as pre-commit hook #471
additional packages need:
npm install --save-dev stylelint stylelint-config-standard stylelint-config-standard-scss pre-commit
I see we have a Next.js project with SASS and TailwindCSS. I set up a pre-commit hook to lint CSS files. I'll use Stylelint for this purpose. I'll create the necessary configuration files and update the package.json
Summary by CodeRabbit
New Features
Chores