Fix AMQP 0.9.1 headers regression #10623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Fixes #10620 Up to RabbitMQ 3.12: * When an AMQP 0.9.1 publisher sends a message with P_basic.headers unset, RabbitMQ will deliver an AMQP 0.9.1 message with P_basic.headers unset. * When an AMQP 0.9.1 publisher sends a message with P_basic.headers being an empty list ([]), RabbitMQ will deliver an AMQP 0.9.1 message with P_basic.headers being an empty list ([]). In 3.13 including message containers, the 1st behaviour stayed the same while the 2nd behaviour changed to: * When an AMQP 0.9.1 publisher sends a message with P_basic.headers being an empty list ([]), RabbitMQ will deliver an AMQP 0.9.1 message with P_basic.headers unset. This commit fixes this regression by using the same behaviour as in 3.12.
kjnilsson approved these changes Feb 27, 2024
michaelklishin added a commit that referenced this pull request Feb 27, 2024
Fix AMQP 0.9.1 headers regression (backport #10623)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #10620
Up to RabbitMQ 3.12:
In 3.13 including message containers, the 1st behaviour stayed the same while the 2nd behaviour changed to:
This commit fixes this regression by using the same behaviour as in 3.12.