Extend FederationSpec with QueueType and ResourceCleanupMode #974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
|
|
jaroslaw-bochniak force-pushed the federation-upstream-definition branch from f786a0f to f1cec7e Compare Contributor Author
| Thank you @michaelklishin, I appreciate quick turn around. I have updated dependency to |
Contributor
| @MirahImage @Zerpet this should now be ready for reviewing. |
MirahImage approved these changes Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This closes #852
Summary Of Changes
Since RabbitMQ
3.13.1, it is possible to configure the queue type in exchange federation. The Federation CRD does not support this field yet. This PR adds possibility to define queue type and resource cleanup mode in definition of the federation.Support in the RabbitMQ client has been added in this PR michaelklishin/rabbit-hole#341
Additional Context
https://www.rabbitmq.com/docs/federation-reference#applying-to-federated-exchanges-only
Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed
Note to contributors: remember to re-generate client set if there are any API changes