Skip to content

Conversation

@EnessenE
Copy link
Contributor

@EnessenE EnessenE commented Mar 27, 2025

This closes nothing

Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed
Note to contributors: remember to re-generate client set if there are any API changes

Summary Of Changes

I noticed the binding example mentioned here doesn't provide arguments. So I added some.

Additional Context

Neither the website or the examples tell you that you can provide arguments, unless you dive into the source code.

I noticed the binding example mentioned here doesn't provide arguments. So I added some
Copy link
Member

@Zerpet Zerpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Those are useful for e.g. header exchanges. They are mentioned in the AMQP tutorial

@Zerpet Zerpet merged commit 88167bd into rabbitmq:main Mar 27, 2025
2 checks passed
@EnessenE
Copy link
Contributor Author

Oh yes, I am aware of their existence. Do not worry about that, I was eluding to the operators docs not mentioning their existence. I will probably submit a pr later for those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants