Skip to content

Conversation

@AntonAleksandrov13
Copy link
Contributor

This closes #906

Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed
Note to contributors: remember to re-generate client set if there are any API changes

Summary Of Changes

MAX_CONCURRENT_RECONCILES changes MaxConcurrentReconciles in TopologyReconciler and SuperStreamReconciler

@vmwclabot
Copy link

@AntonAleksandrov13, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

@vmwclabot
Copy link

@AntonAleksandrov13, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

@Zerpet Zerpet self-assigned this Dec 2, 2024
@Zerpet Zerpet added this to the v1.16.0 milestone Dec 2, 2024
@Zerpet Zerpet self-requested a review December 2, 2024 17:51
Copy link
Member

@Zerpet Zerpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'll merge after CI passes.

@vmwclabot
Copy link

@AntonAleksandrov13, your company's legal contact did not review your signed contributor license agreement within the 14 day limit. The merge can not proceed. Click here to resign the agreement.

@vmwclabot
Copy link

@AntonAleksandrov13, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

@AntonAleksandrov13
Copy link
Contributor Author

@Zerpet I see that all checks, but one went though. Do I need to do anything?

@Zerpet
Copy link
Member

Zerpet commented Jan 3, 2025

@AntonAleksandrov13 it looks like the check for the CLA bot has not reported back to GitHub. Let me double check with a colleague, I'll circle back.

@michaelklishin
Copy link
Contributor

@vmwclabot this is an obvious change

@Zerpet
Copy link
Member

Zerpet commented Jan 8, 2025

Merging since the bot does not seem relevant nowadays.

@Zerpet Zerpet merged commit 62f01be into rabbitmq:main Jan 8, 2025
7 of 8 checks passed
@vmwclabot

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants