Refactor and fix OLM packaging and workflow #1004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
We are using a "generator" template and applying values on top, instead of using overlays to modify specific parts of the generator file. The Makefile is a new approach to script the commands, instead of using Python in the original OLM dedicated git repo. The future idea is to fold the OLM manifests repo into this one, for the specific bits of topology operator.
We were creating policies with mirroring keys, that are not valid in RabbitMQ 4. Some readiness steps were asserting on number of global parameters present, which has changed in RMQ 4 with the vhost tags. Now we assert on the presence on specific parameter.
Member Author
| @MirahImage FYI I had to make some changes to system tests to get them to pass. Along the way, I changed the system tests to use RabbitMQ 4, which required some further changes. Any feedback on the refactoring is welcome. Feel free to ignore the OLM bits 🙂 |
MirahImage approved these changes Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary Of Changes
Additional Context
TLS tests are skipped because we don't deploy cert-manager. Cert-manager bundle in OLM is deprecated.