Fix reusing the url variable in concurrency tutorial #825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
rede3g reviewed Feb 19, 2025
concurrency/v3/check_websites.go Outdated
| resultChannel := make(chan result) | ||
| | ||
| for _, url := range urls { | ||
| u := url |
There was a problem hiding this comment.
It be better to add a Parameter in the function instead declaring the variable . Like
go func(url string) { resultChannel <- result{url, wc(url)} }(url)Signed-off-by: Eduard Kaverinskyi <eduard.kaverinskyi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The current version's tests didn't work for me at the end of the section. I propose a fix.
The exact wording or maybe even the implementation may be improved/modified, but I think this should be covered in the tutorial.