Skip to content

Fix context range precision gap #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2024
Merged

Fix context range precision gap #123

merged 1 commit into from
Apr 25, 2024

Conversation

ddelemeny
Copy link
Collaborator

When looking backwards on a searchAfter request, createContextTimerange creates a range which does not contain the searchAfter target timestamp row.timeEpochNs because of truncated precision.

This PR does the following :

  • offset the higher bound by 1 Ms to make sure that the target timestamp is within the bounds after truncation.
  • add a test to check that scenario
fmassot
fmassot reviewed Apr 25, 2024
View reviewed changes
@ddelemeny ddelemeny force-pushed the ddelemeny/fix-context-range branch 2 times, most recently from 57ff6ae to 02c9a22 Compare April 25, 2024 19:24
@ddelemeny ddelemeny force-pushed the ddelemeny/fix-context-range branch from 02c9a22 to a8d8cab Compare April 25, 2024 19:32
@ddelemeny ddelemeny merged commit 8afe6fb into main Apr 25, 2024
@ddelemeny ddelemeny deleted the ddelemeny/fix-context-range branch May 20, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@ddelemeny @fmassot