Add JS_SealObject and JS_FreezeObject methods #819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
bnoordhuis reviewed Jan 11, 2025
bnoordhuis requested changes Jan 12, 2025
| Apparently, calling "git add" prior to committing really helps^^ |
saghul reviewed Jan 12, 2025
ABBAPOH force-pushed the seal branch 2 times, most recently from c638925 to fda984f Compare bnoordhuis reviewed Jan 12, 2025
ABBAPOH changed the title bnoordhuis reviewed Jan 13, 2025
bnoordhuis approved these changes Jan 14, 2025
There was a problem hiding this comment.
LGTM. New API so it'd be good to get sign-off from at least one other committer. @saghul?
saghul approved these changes Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
For optimisation, we share some huge objects in different scripts and make them "const" to prevent user from accidentally changing them.