Skip to content

Implement Iterator.prototype.flatMap #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2024
Merged

Implement Iterator.prototype.flatMap #684

merged 1 commit into from
Nov 14, 2024

Conversation

saghul
Copy link
Contributor

@saghul saghul commented Nov 13, 2024

No description provided.

@saghul saghul requested a review from bnoordhuis November 13, 2024 21:32
@saghul saghul force-pushed the iterator-helpers-flatmap branch from 42f3f39 to b09450c Compare November 13, 2024 21:37
@saghul
Copy link
Contributor Author

saghul commented Nov 13, 2024 •
edited
Loading

Phew, this was the hardest of them all...

@bnoordhuis Proposal: aftewr this lands, I'll update some docs and cut a release.

Then do a bit of cleanup, I see some opportunities to DRY some code. WDYT? Anything else you'd like to do before releasing?
@saghul
Copy link
Contributor Author

saghul commented Nov 13, 2024

Valgrind run, just in case: https://github.com/quickjs-ng/quickjs/actions/runs/11826283390
bnoordhuis
bnoordhuis approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
@bnoordhuis
Copy link
Contributor

Anything else you'd like to do before releasing?

I'd like to fix #683 (should be trivial) and I've been thinking about releasing amalgamated builds but that doesn't have to hold up this release. I'll open an issue to discuss.
@bnoordhuis
Copy link
Contributor

Oh, I guess we still have a few Iterator failures in test262_errors.txt, with a few more after updating test262. Maybe they're harmless but it'd be good to look into them before cutting a release.
@saghul
Copy link
Contributor Author

saghul commented Nov 14, 2024

Oh, I guess we still have a few Iterator failures in test262_errors.txt, with a few more after updating test262. Maybe they're harmless but it'd be good to look into them before cutting a release.

I'll take a look. Some of them were there before and some were fringe cases but I'll double check!
@saghul saghul merged commit 6d7448e into master Nov 14, 2024
48 checks passed
@saghul saghul deleted the iterator-helpers-flatmap branch November 14, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@saghul @bnoordhuis