Fix use of js_malloc_usable_size #544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
saghul force-pushed the fix-malloc-usable-size branch 5 times, most recently from 96799fd to 43cfa42 Compare Make sure the one set in the malloc functions is used rather than the default one, since it will likely use a different allocator. For some reason, this didn't cause a problem on macOS, but it does in Linux. Opsie! Added some CI to prevent these kinds of bugs.
saghul force-pushed the fix-malloc-usable-size branch from 43cfa42 to 7e151e1 Compare | Will do a .1 release after this, since the custom allocator thing got botched :-/ |
bnoordhuis approved these changes Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Make sure the one set in the malloc functions is used rather than the default one, since it will likely use a different allocator.
For some reason, this didn't cause a problem on macOS, but it does in Linux. Opsie! Added some CI to prevent these kinds of bugs.