Introduce JS_ReadObject2 #468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Analogously to JS_WriteObject2, it allows the user to get a tab with all the SAB objects that were read. This can help adjust reference counts in a scenario where a SAB that was written increased it and it's necessary to decrease it upon reading it.
| @chqrlie PTAL. Context: my Worker implementation sends the serialized data over a socketpair, so being able to dup the SAB upon write and free it upon read would make my life easier :-) |
chqrlie reviewed Jul 15, 2024
I have very little connectivity ATM, sorry for the lag. |
No worries, I just posted this today :-P |
| @chqrlie Updated, PTAL when you can! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Analogously to JS_WriteObject2, it allows the user to get a tab with all the SAB objects that were read.
This can help adjust reference counts in a scenario where a SAB that was written increased it and it's necessary to decrease it upon reading it.