Improve dump option support #344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| This needs a rebase now that you did the split and the other stuff can be merged. |
Yes, I am aware of this and it would have been difficult to avoid it. |
| Yes you can do that. Make sure to use --force then. |
chqrlie force-pushed the improve-dump-options branch from fc3b2bd to 43a7fc3 Compare 
- DUMP_XXX defined as nothing or 0 produces unconditional output - DUMP_XXX defined as a bitmask produces conditional output based on command line option -d<bitmask> - add `JS_SetDumpFlags()` to select active dump options - accept -d[<hex mask>] and --dump[=<hex mask>] to specify active dump options, generalize command line option handling - improve DUMP_READ_OBJECT output, fix indentation issue
chqrlie force-pushed the improve-dump-options branch from 43a7fc3 to 1692198 Compare 
saghul approved these changes Apr 9, 2024
| @bnoordhuis do you have any remarks? can I proceed and merge this? |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
JS_SetDumpFlags()to select active dump optionsDUMP_XXXoutput dynamically selectableDUMP_READ_OBJECToutput, fix indentation issue