Fix the issue of incorrect time range calculation across days #718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Also encountered this: Sunday (13th) 2AM is not expected to be in range for the below config (expected to be down from Friday 3 AM till Sunday 6PM) edit: or expected to be down from Saturday 3 AM till Sunday 6PM? |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The current IsInRange() method produces incorrect results when the time range crosses midnight (StartTime > EndTime) and "Weekdays" is configured. For example, when Weekdays=[Sunday, Monday, Tuesday, Wednesday, Thursday], the system will incorrectly identify Friday's time period as not belonging to the time period.
Reproduce
Config:
IsInRange() result before change:
IsInRange() result after change: