[Bug] Fix UriOverrider::isTargetUri with different paths #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Kevinrob changed the title 
Contributor
| Hi Kevin, Thank you for using our SDK and the help with the bugfix. However, we don't apply changes directly to our code here in GitHub. It should go through our internal processes and pipelines. So, I have to close this PR. Best regards, |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
We have a use case where the alternate page is on the same domain as the target page.
I think it's just a typo, but the code is not properly checking the path. The alternate URL is detected as the target URL.