Skip to content

use localhost instead of 127.0.0.1 in examples #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
glasstiger merged 2 commits into from
Sep 26, 2022
Merged

use localhost instead of 127.0.0.1 in examples #9

glasstiger merged 2 commits into from
Sep 26, 2022

Conversation

@argshook
Copy link
Contributor

@argshook argshook commented Sep 26, 2022

in This PR:

  • format example code with prettier
  • use localhost instead of 127.0.0.1 in examples

The example code is used in other code bases to showcase how this client
should be used.

It is also used with examples.manifest.yaml, which describes examples with interpolatable values.

In particular, the examples.manifest.yaml has these:

 addr: host: localhost port: 9009

when example code like ./examples/basic.js is interpolated with values from examples.manifest.yaml, the host part is missed.

Thus, we should be consistent and in both examples.manifest.yaml and examples/*.js use as host either:

  1. localhost or
  2. 127.0.0.1

This PR chooses localhost
@argshook
format example code
4bfecf0 
use prettier for example snippets. The result is code formatted in a way more familiar way for javascript developer
@argshook
use localhost instead of 127.0.0.1 in examples
a10758f
@argshook argshook self-assigned this Sep 26, 2022
@argshook argshook requested a review from glasstiger September 26, 2022 10:29
@glasstiger glasstiger merged commit d268dc2 into main Sep 26, 2022
@argshook argshook deleted the fix-host-in-examples branch September 26, 2022 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants

@argshook @insmac @glasstiger