Skip to content

feat(nodejs): HTTP transport, configuration string, new config options #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
glasstiger merged 31 commits into from
Apr 29, 2024
Merged

feat(nodejs): HTTP transport, configuration string, new config options #26

glasstiger merged 31 commits into from
Apr 29, 2024

Conversation

@glasstiger
Copy link
Collaborator

@glasstiger glasstiger commented Apr 15, 2024 •
edited
Loading

Support for ILP@HTTP, configuration string and new config options.
@glasstiger glasstiger marked this pull request as draft April 15, 2024 09:42
@glasstiger glasstiger marked this pull request as ready for review April 17, 2024 10:16
@nwoolmer nwoolmer self-requested a review April 19, 2024 08:30
nwoolmer
nwoolmer reviewed Apr 19, 2024
View reviewed changes
Copy link
Contributor

@nwoolmer nwoolmer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me, some minor suggestions and questions.

Also, a CONTRIBUTING.md would help for future dev around set up and testing.
puzpuzpuz
puzpuzpuz reviewed Apr 22, 2024
View reviewed changes
glasstiger and others added 20 commits April 22, 2024 13:03
@glasstiger @nwoolmer
Update src/sender.js
d2b433d 
Co-authored-by: Nick Woolmer <29717167+nwoolmer@users.noreply.github.com>
@glasstiger @nwoolmer
Update src/sender.js
408dcd0 
Co-authored-by: Nick Woolmer <29717167+nwoolmer@users.noreply.github.com>
@glasstiger @nwoolmer
Update src/options.js
da538fb 
Co-authored-by: Nick Woolmer <29717167+nwoolmer@users.noreply.github.com>
@glasstiger @nwoolmer
Update src/options.js
5d864de 
Co-authored-by: Nick Woolmer <29717167+nwoolmer@users.noreply.github.com>
@glasstiger @nwoolmer
Update src/options.js
669234f 
Co-authored-by: Nick Woolmer <29717167+nwoolmer@users.noreply.github.com>
@glasstiger @nwoolmer
Update src/options.js
3a1e407 
Co-authored-by: Nick Woolmer <29717167+nwoolmer@users.noreply.github.com>
@glasstiger @nwoolmer
Update src/options.js
7330c75 
Co-authored-by: Nick Woolmer <29717167+nwoolmer@users.noreply.github.com>
@glasstiger @nwoolmer
Update types/src/sender.d.ts
feeb940 
Co-authored-by: Nick Woolmer <29717167+nwoolmer@users.noreply.github.com>
@glasstiger @nwoolmer
Update src/options.js
9fef9f3 
Co-authored-by: Nick Woolmer <29717167+nwoolmer@users.noreply.github.com>
@glasstiger @nwoolmer
Update src/options.js
1d0c64e 
Co-authored-by: Nick Woolmer <29717167+nwoolmer@users.noreply.github.com>
@glasstiger
use sender's logger
efeaef2
@glasstiger
destroy request before retry
7cb6c57
@glasstiger
fix test to work with different node versions
c16bf65
@glasstiger
custom http agent option
9b9c4d0
@glasstiger
custom http agent options
64ffab8
@glasstiger
destroy default http agents when last sender is closed
994318c
@glasstiger
buffer size comment + jsdoc fix
f5d5ab3
@glasstiger
tsc + jsdoc generated
390a524
@glasstiger
fixing tests
9b607b9
@glasstiger
fix test depends on node version
f2a5a74
puzpuzpuz
puzpuzpuz reviewed Apr 25, 2024
View reviewed changes
glasstiger and others added 2 commits April 25, 2024 11:11
@glasstiger @puzpuzpuz
Update src/options.js
c241667 
Co-authored-by: Andrei Pechkurov <37772591+puzpuzpuz@users.noreply.github.com>
@glasstiger
separate counters for http and tcp
b0dd22e
@puzpuzpuz puzpuzpuz added the enhancement New feature or request label Apr 26, 2024
puzpuzpuz
puzpuzpuz reviewed Apr 29, 2024
View reviewed changes
puzpuzpuz
puzpuzpuz approved these changes Apr 29, 2024
View reviewed changes
Copy link
Collaborator

@puzpuzpuz puzpuzpuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!
@glasstiger glasstiger merged commit 97a5f9e into main Apr 29, 2024
@glasstiger
Copy link
Collaborator Author

glasstiger commented Apr 29, 2024

Thank you for the reviews and the support @puzpuzpuz and @nwoolmer !
@puzpuzpuz puzpuzpuz deleted the ilp_http branch April 29, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

4 participants

@glasstiger @nwoolmer @puzpuzpuz