Added debug option and remove unneded async #11
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
|
|
glasstiger reviewed Jan 4, 2023
| * @return {Promise<boolean>} Resolves to true if there was data in the buffer to send. | ||
| */ | ||
| async flush() { | ||
| flush() { |
Collaborator
There was a problem hiding this comment.
would keep async here because of the return false; line
| } | ||
| this.resize(options && options.bufferSize ? options.bufferSize : DEFAULT_BUFFER_SIZE); | ||
| this.reset(); | ||
| this.debug = options.debug || false; |
Collaborator
There was a problem hiding this comment.
|| false likely does nothing.
this line could look like this instead:
this.debug = options && options.debug; 
Collaborator
| Closing this PR because now we have the option to pass a custom logger to the client. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Add support to enable/disable the debug to use the console.info messages.
By default the debug is false, but in case the user sends true in the options, it will show the console messages.
Also removed some unneeded
asynckeywords.This is to solve #12