Skip to content

feat(client): add table and column name length validation #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 4, 2022
Merged

feat(client): add table and column name length validation #1

merged 2 commits into from
Jul 4, 2022

Conversation

puzpuzpuz
Copy link
Collaborator

No description provided.

@puzpuzpuz puzpuzpuz added the enhancement New feature or request label Jun 30, 2022
@puzpuzpuz puzpuzpuz self-assigned this Jun 30, 2022
jerrinot
jerrinot reviewed Jun 30, 2022
View reviewed changes
bluestreak01
bluestreak01 requested changes Jun 30, 2022
View reviewed changes
@bluestreak01
Copy link
Member

bluestreak01 commented Jun 30, 2022 •
edited
Loading

could we have CI setup ? Would you like help with that ?
@puzpuzpuz
Copy link
Collaborator Author

could we have CI setup ? Would you like help with that ?

Not sure if I follow. CI is there and it's configured via GHA. See https://github.com/questdb/go-questdb-client/runs/7130372131?check_suite_focus=true to find the last build.
@amunra
Copy link
Contributor

amunra commented Jun 30, 2022 

 public static boolean isValidColumnName(CharSequence seq, int fsFileNameLimit) { int l = seq.length(); if (l > fsFileNameLimit) { // Most file systems don't support files name longer than 255 bytes return false; }

I haven't spotted validation of column name length. Have I missed it?
@amunra
Copy link
Contributor

amunra commented Jun 30, 2022 

 public static boolean isValidColumnName(CharSequence seq, int fsFileNameLimit) { int l = seq.length(); if (l > fsFileNameLimit) { // Most file systems don't support files name longer than 255 bytes return false; }

I haven't spotted validation of column name length. Have I missed it?

It's in writeColumnName, I missed it :-)
@puzpuzpuz
Copy link
Collaborator Author

It's in writeColumnName, I missed it :-)

Yup, it's there.
@bluestreak01 bluestreak01 merged commit 41ae846 into main Jul 4, 2022
@bluestreak01 bluestreak01 deleted the add_table_name_length_validation branch July 4, 2022 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

4 participants

@puzpuzpuz @bluestreak01 @amunra @jerrinot