perf: optimised marker operations removing heap allocations #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ideoma approved these changes Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Overview
Performance fix which avoids heap allocation when setting a new marker.
This change is a performance optimisation without any changes in functionality.
Context
Buffers can be wound back to a previous point using markers.
The markers remember and reset internal tracking state of the buffer, making easy to revert back to a previous condition after an error.
Saving a marker previously involved allocating memory for the table name.
We now internally only store the length of the table name instead.
N.B.: