Update tesseract.perf.cc #128
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
got these warnings building on macos: ``` src/tesseract.perf.cc:51:29: warning: compound assignment to object of volatile-qualified type 'volatile size_t' (aka 'volatile unsigned long') is deprecated [-Wdeprecated-volatile] total_num_errors_used += decoder.predicted_errors_buffer.size(); ^ src/tesseract.perf.cc:87:3: note: in instantiation of function template specialization 'benchmark_decoder<TesseractDecoder>' requested here benchmark_decoder(decoder, circuit, num_shots); ^ src/tesseract.perf.cc:51:29: warning: compound assignment to object of volatile-qualified type 'volatile size_t' (aka 'volatile unsigned long') is deprecated [-Wdeprecated-volatile] total_num_errors_used += decoder.predicted_errors_buffer.size(); ^ src/tesseract.perf.cc:108:3: note: in instantiation of function template specialization 'benchmark_decoder<SimplexDecoder>' requested here benchmark_decoder(decoder, circuit, num_shots); ^ 2 warnings generated. INFO: From Linking src/tesseract_perf: ``` fair enough and we don't need volatile because the cout is a side effect. I sort of wish there were a language feature for not optimizing out variables in C++...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
got these warnings building on macos:
fair enough and we don't need volatile because the cout is a side effect. I sort of wish there were a language feature for not optimizing out variables in C++...