Skip to content

Don't use URLDecoder to decode file URLs in ConfigurationWatchList #951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Don't use URLDecoder to decode file URLs in ConfigurationWatchList #951

wants to merge 1 commit into from

Conversation

dnl50
Copy link

@dnl50 dnl50 commented Jun 28, 2025

Java's File#toURI method does not encode all reserved URI characters like the + character, because they only need to be encoded in other parts of the URI. The java.net.URLDecoder on the other hand expects the x-www-form-urlencode encoding and therefore replaces these characters. Automatic reloading of logback configuration files in directories with the + did therefore not work. Fixes #950
@dnl50
Don't use URLDecoder to decode file URLs in ConfigurationWatchList
1022112 
Java's `File#toURI` method does not encode all reserved URI characters like the `+` character, because they only need to be encoded in other parts of the URI. The `java.net.URLDecoder` on the other hand expects the `x-www-form-urlencode` encoding and therefore replaces these characters. Automatic reloading of logback configuration files in directories with the `+` did therefore not work. Fixes qos-ch#950 Signed-off-by: Daniel Meier <danielmeier50@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant
@dnl50