Skip to content

Align RequestURI attribute creation in Jetty 12 with Jetty 11 approach. #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ceki merged 1 commit into from
Apr 4, 2024
Merged

Align RequestURI attribute creation in Jetty 12 with Jetty 11 approach. #5

ceki merged 1 commit into from
Apr 4, 2024
+9 −9

Conversation

@sondemar
Copy link
Contributor

@sondemar sondemar commented Apr 2, 2024

closes #4
@sondemar sondemar mentioned this pull request Apr 2, 2024
Closed
sondemar
sondemar commented Apr 2, 2024
View reviewed changes
jetty12/src/test/java/ch/qos/logback/access/jetty/SiftingAppenderTest.java
witnessSet.add(prefix);
witnessSet.add(prefix+"x");
witnessSet.add(prefix+"y");
Set<String> witnessSet = new LinkedHashSet<>();
Copy link
Contributor Author

@sondemar sondemar Apr 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compliant with https://github.com/sondemar/logback-access/blob/0e1f57a69891df361e221a82f083619be6b97451/jetty11/src/test/java/ch/qos/logback/access/jetty/SiftingAppenderTest.java#L53
@ceki
Copy link
Member

ceki commented Apr 4, 2024

@sondemar Thank you for this PR. It fails DCO check. You should be able to add the proper sign-off with the help of the instructions in the DCO check link above.
@sondemar
Align RequestURI attribute creation in Jetty 12 with Jetty 11 approach.
5c8d531 
Signed-off-by: mariusz.sondecki <mariusz.sondecki@auto1.com>
@sondemar sondemar force-pushed the refine-requestURI-in-jetty12 branch from 0e1f57a to 5c8d531 Compare April 4, 2024 19:31
@sondemar
Copy link
Contributor Author

sondemar commented Apr 4, 2024

@sondemar Thank you for this PR. It fails DCO check. You should be able to add the proper sign-off with the help of the instructions in the DCO check link above.

@ceki , now it should be fine
@ceki ceki merged commit b231a59 into qos-ch:main Apr 4, 2024
@ceki
Copy link
Member

ceki commented Apr 9, 2024

@sondemar Logback-access version 2.0.1 containing this fix has been released earlier today.
@sondemar
Copy link
Contributor Author

sondemar commented Apr 9, 2024

@sondemar Logback-access version 2.0.1 containing this fix has been released earlier today.

Thank you @ceki
@marinedayo marinedayo mentioned this pull request Apr 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@sondemar @ceki