Supports string and array settings for file_extensions config #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
chrishulton force-pushed the chris/does-this-build branch from f9d8821 to b09a601 Compare 
maxjacobson approved these changes May 9, 2017
Contributor
maxjacobson left a comment
maxjacobson left a comment There was a problem hiding this comment.
Great branch name 😄
Seems like this build breaks fairly easily... I had to make some fixes recently to get the build going again then... hm.
This fix LGTM though. If we have support for proper arrays, that's way better than CSV-style lists.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Addresses error:
Our docs are inconsistent about how to specify this setting, ie:
vs
We could just update the docs, but it is easy enough to support both. I did not add a spec for this, but I tested it out with a local repo.
In order to make this change, I had to update the Dockerfile to get the image building. I also decided to update the dependencies while in here, which required a fix to the Makefile.