Skip to content

Conversation

@SimonQuantumhw
Copy link

What are the issues this pull addresses (issue numbers / links)?

Did you add tests to cover your changes (yes/no)?

Did you update the documentation accordingly (yes/no)?

Did you read the CONTRIBUTING document (yes/no)?

Summary

Adding logo, Creating Qcomponents from Images

Details and comments

@CLAassistant
Copy link

CLAassistant commented Jun 23, 2023

CLA assistant check
All committers have signed the CLA.

@zlatko-minev
Copy link
Collaborator

Hi Simon, congratulations on your first pull request on the new repo, thank you very much for making it. Have you signed the CLA above?

@zlatko-minev zlatko-minev self-assigned this Jun 23, 2023
@zlatko-minev
Copy link
Collaborator

Let me know if you see these messages

@SimonQuantumhw
Copy link
Author

I see the messages

@zlatko-minev
Copy link
Collaborator

Thanks, @SimonTheRocketGuy !

Some questions:

  1. Do we need another license file? tutorials/5 Logo_from_img/Qiskit_Metal-Add_Logo/LICENSE There is already an APACHE license at the top of the repo. We don't usually add per module licenses
@zlatko-minev
Copy link
Collaborator

Could we also move the tutorial folders to organize and keep concisent with the rest of the repo.

Perhaps placing them under a folder

  • Appendix C - Quick Examples / F. Custom special components

Then we can add them to the docs from there in the auto gallery

@SimonQuantumhw
Copy link
Author

OH... yesss! License is there by a mistake. I added it to every repo in my git account auto and then it just copied here... Of course! That would be great! I did not know where to place it at first... Thanks!

@zlatko-minev
Copy link
Collaborator

Thanks, feel free to update the PR here so i can check and merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants