Skip to content

Conversation

@qihqi
Copy link
Collaborator

@qihqi qihqi commented Apr 15, 2025

Also reapplied formatting changes becuase of new yapf version. The old version is no longer available in the new OS version.

@qihqi qihqi requested a review from tengyifei April 15, 2025 21:05
Copy link
Collaborator

@tengyifei tengyifei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubberstamped.

However, upgrading yapf and clang-format broke the formatting tests. Consider pinning yapf and clang-format.

@tengyifei tengyifei merged commit a37a585 into master Apr 16, 2025
24 checks passed
@tengyifei tengyifei mentioned this pull request Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants