Skip to content

Remove deprecated typing module in ansible flow #8955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2025
Merged

Remove deprecated typing module in ansible flow #8955

merged 1 commit into from
Apr 10, 2025

Conversation

@tengyifei
Copy link
Collaborator

Remove deprecated typing module (it's built into Python now).
@tengyifei
Try to fix nightly build
7dfab55 
Remove deprecated typing module (it's built into Python now).
@tengyifei tengyifei changed the title Try to fix nightly build Remove deprecated typing module in ansible flow Apr 10, 2025
@tengyifei tengyifei marked this pull request as ready for review April 10, 2025 05:48
@zpcore
Copy link
Member

zpcore commented Apr 10, 2025

Curious what is the build error you see?
@qihqi qihqi merged commit e77bd2f into master Apr 10, 2025
24 checks passed
@tengyifei
Copy link
Collaborator Author

Curious what is the build error you see?

The error was

Step #2 - "build_xla_docker_image":   stdout: |- Step #2 - "build_xla_docker_image":     Building wheel torch-2.8.0 Step #2 - "build_xla_docker_image":     invalid command 'bdist_wheel'

So the PyTorch upstream setup.py does not support bdist_wheel. The LLM told me it could be a problem in the wheel package. I didn't find what's the problem, but I saw this unrelated tech debt which is we are installing an unnecessary typings package. Hence fix here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@tengyifei @zpcore @qihqi