Skip to content

Correct type conversions in OpBuilder and add corresponding test. #8873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2025
Merged

Correct type conversions in OpBuilder and add corresponding test. #8873

merged 1 commit into from
Mar 24, 2025

Conversation

@iwknow
Copy link
Collaborator

@iwknow iwknow commented Mar 22, 2025 •
edited
Loading

This PR contains two changes:

  1. Correct type conversion bug in xla_builder
  2. Add unit test on the type conversion to ensure that correctness of the conversion functions.

This PR fixes #8798 (comment)
@iwknow
Copy link
Collaborator Author

iwknow commented Mar 22, 2025

@rpsilva-aws
@tengyifei
Copy link
Collaborator

Let's see if CI complains
@tengyifei tengyifei merged commit f2bdecf into pytorch:master Mar 24, 2025
23 checks passed
@iwknow iwknow deleted the type_conversion branch March 30, 2025 01:55
@rpsilva-aws rpsilva-aws mentioned this pull request May 1, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@iwknow @tengyifei