Attach callback to a Tensor's underlying buffer #7793
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
torch_xla.experimental.callback.on_ready_callbackto install callback ((Tensor) -> None) on Tensor, to be called when underlying buffer is readyFuturebecauseTensors are already async results in our case, and returningFutureswould require expanding the API in several places.void()to make Pybind plumbing easiercallbackdoes need to reacquire the GIL from the main threadthread apply all btfromgdbwould be extremely helpful for me to debug.PrepareToExitnow waits for pending runtime operations to complete. Otherwise, we start destroying the runtime client before operations are done. If the main thread is waiting for a callback to complete, a deadlock occurs.