[while_loop] prepare for torch while_loop signature change. #6872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| cc. @ManfeiBai |
qihqi approved these changes Apr 2, 2024
| Hi, the tests seem passing. Can we merge it? |
JackCaoG approved these changes Apr 2, 2024
pytorchmergebot pushed a commit to pytorch/pytorch that referenced this pull request Apr 3, 2024
#123018 introduces a necessary bc breaking change and sees a bunch of xla test failures on CI. We made a pr to pytorch/xla to prepare for the breaking change pytorch/xla#6872. We update the pin of pytorch/xla to reflect the change in this PR. Pull Request resolved: #123217 Approved by: https://github.com/clee2000
sanketpurandare pushed a commit to sanketpurandare/pytorch that referenced this pull request Apr 22, 2024
pytorch#123018 introduces a necessary bc breaking change and sees a bunch of xla test failures on CI. We made a pr to pytorch/xla to prepare for the breaking change pytorch/xla#6872. We update the pin of pytorch/xla to reflect the change in this PR. Pull Request resolved: pytorch#123217 Approved by: https://github.com/clee2000
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
In pytorch/pytorch#123018, we add support for closures, params and buffers to while_loop in pytorch but it's failing XLA tests here https://hud.pytorch.org/pr/pytorch/pytorch/123018#23324185080 because the signature of the implantation of DispatchKey.xla needs to be modified. This pr prepares xla key implementation to accept additional_inputs.
Right now, it's just a None value. We need to add proper support for
additional_inputsin _xla_while_loop and probably add more tests for closures, parameters and buffers when pytorch/pytorch#123018 ships.