Add limit to max inflight TPU computations #6533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
alanwaketan reviewed Feb 14, 2024
| def physical_chip_count(self): | ||
| return num_available_chips() | ||
| | ||
| def client_create_options(self): |
There was a problem hiding this comment.
who calls this method?
There was a problem hiding this comment.
The parent class' virtual method is pybinded and called during client creation here:
There was a problem hiding this comment.
Thanks, Will. Hard to tell it it's a virtual method in pythong. haha
miladm reviewed Feb 16, 2024
| def client_create_options(self): | ||
| return { | ||
| 'max_inflight_computations': | ||
| xu.getenv_as('XLA_TPU_MAX_INFLIGHT_COMPUTATIONS', int, 4) |
There was a problem hiding this comment.
shall we track this new variable in https://github.com/pytorch/xla/blob/master/configuration.yaml @will-cromar?
cc @wonjoolee95
amithrm pushed a commit to amithrm/xla that referenced this pull request Mar 1, 2024
bhavya01 pushed a commit that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Requires
XLA_REGISTER_INSTALLED_PLUGINS=1to useDevicePluginAPI.