[FSDPv2] Use the global mesh API #6500
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jonb377 approved these changes Feb 8, 2024
| Thanks, Jon! |
Summary: Make FSDPv2 to use the global mesh API such that users can just set the global mesh. Test Plan: python test/spmd/test_fsdp_v2.py -v -k test_fsdp_v2_global_mesh
alanwaketan force-pushed the alanwaketan/fsdp_v2_global branch from 9cede36 to b3e2fad Compare | Let's skip the GPU tests given the pre-rebased one has passed all. |
5 tasks
amithrm pushed a commit to amithrm/xla that referenced this pull request Mar 1, 2024
Summary: Make FSDPv2 to use the global mesh API such that users can just set the global mesh. Test Plan: python test/spmd/test_fsdp_v2.py -v -k test_fsdp_v2_global_mesh
bhavya01 pushed a commit that referenced this pull request Apr 22, 2024
Summary: Make FSDPv2 to use the global mesh API such that users can just set the global mesh. Test Plan: python test/spmd/test_fsdp_v2.py -v -k test_fsdp_v2_global_mesh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary:
Make FSDPv2 to use the global mesh API such that users can just set the global mesh.
Test Plan:
python test/spmd/test_fsdp_v2.py -v -k test_fsdp_v2_global_mesh