[SPMD] Introduce global mesh #6498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Summary: SPMD expects the mesh to be the same across the board. Therefore, introduce the concept of a global mesh to reduce the need to carry the same mesh in the code. Test Plan: python test/spmd/test_xla_sharding.py -v -k test_global_mesh
jonb377 approved these changes Feb 7, 2024
There was a problem hiding this comment.
Looks great, thanks for adding this Jiewen!
Do you want to add a section to the spmd.md doc about the usage? It could be useful to explain why a global mesh is needed. (I'll also take an AI to update our resnet example to use a single mesh across the program)
| Thanks for the quick review, Jon. Let me do the doc update later. I'm in a rush... |
| Let's ignore the GPU test given it takes forever. I'm in a very tight deadline. |
5 tasks
amithrm pushed a commit to amithrm/xla that referenced this pull request Mar 1, 2024
Summary: SPMD expects the mesh to be the same across the board. Therefore, introduce the concept of a global mesh to reduce the need to carry the same mesh in the code. Test Plan: python test/spmd/test_xla_sharding.py -v -k test_global_mesh
bhavya01 pushed a commit that referenced this pull request Apr 22, 2024
Summary: SPMD expects the mesh to be the same across the board. Therefore, introduce the concept of a global mesh to reduce the need to carry the same mesh in the code. Test Plan: python test/spmd/test_xla_sharding.py -v -k test_global_mesh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary:
SPMD expects the mesh to be the same across the board. Therefore, introduce the concept of a global mesh to reduce the need to carry the same mesh in the code.
Test Plan:
python test/spmd/test_xla_sharding.py -v -k test_global_mesh