Skip to content

Conversation

@ManfeiBai
Copy link
Collaborator

cherry-pick #6166

@ManfeiBai ManfeiBai self-assigned this Dec 15, 2023
@ManfeiBai ManfeiBai requested review from qihqi and wonjoo-wj December 15, 2023 18:30
@ManfeiBai ManfeiBai marked this pull request as ready for review December 15, 2023 18:31
@ManfeiBai ManfeiBai changed the title Promote int to float for tanh operation (consistent with Pytorch) (#6166) [Cherry-pick]Promote int to float for tanh operation (consistent with Pytorch) (#6166) Dec 15, 2023
Copy link
Collaborator

@wonjoo-wj wonjoo-wj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's wait for the CI before merging.

Copy link
Collaborator

@qihqi qihqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@ManfeiBai
Copy link
Collaborator Author

this PR is too old and buidl failed due to duplicated image, so created new PR to trigger CI test: #6241

@ManfeiBai
Copy link
Collaborator Author

since #6241 failed too due to duplicated image, will cherry-pick this PR with the next cherry-pick PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants