Add profiler API for async capture #5969
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jonb377 force-pushed the jonbolin/trace branch from f6ad988 to a7579ab Compare 
JackCaoG reviewed Dec 1, 2023
There was a problem hiding this comment.
Thanks a lot! Can we add a test to https://github.com/pytorch/xla/blob/master/test/test_profiler.py ? We already have a test for trace so I imagine you can mostly just copy paste the test and make small modifications.
jonb377 force-pushed the jonbolin/trace branch from ac694c7 to 7297c4e Compare
Thanks @JackCaoG - I generalized the test_profile_mp_mnist script to support programmatic captures and added a test case |
This was referenced Dec 5, 2023
chunnienc pushed a commit to chunnienc/xla that referenced this pull request Dec 14, 2023
* Add profiler API for async capture * Add unit test
golechwierowicz pushed a commit that referenced this pull request Jan 12, 2024
* Add profiler API for async capture * Add unit test
bhavya01 pushed a commit that referenced this pull request Apr 22, 2024
* Add profiler API for async capture * Add unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
To more easily support programmatic captures, this changes add a new API
trace_detachedtotorch_xla.debug.profilerto capture a profile from a background thread.Tested by using the new API in Llama2 training.