fix squeeze op lowering issue when dim is not in sorted order #5751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
lsy323 reviewed Nov 4, 2023
| xla::XlaOp BuildMaskedFillScalar(xla::XlaOp input, xla::XlaOp mask, | ||
| xla::XlaOp scalar); | ||
| | ||
| std::vector<int64_t> BuildSqueezedDimensions( |
There was a problem hiding this comment.
The above one should be a special case of the 2nd one, shall we just keep the second one?
There was a problem hiding this comment.
Thanks for the point, I leave the original signature there in case program still relays on the 1st one. However, I just made the update in 1st one function to call 2nd function to simplify the coding.
mbzomowski pushed a commit to mbzomowski-test-org/xla that referenced this pull request Nov 16, 2023
…h#5751) * fix squeeze op lowering issue when dim is not in sorted order * remove debug info * remove debug info * refactor BuildSqueezedDimensions
ManfeiBai pushed a commit that referenced this pull request Nov 29, 2023
* fix squeeze op lowering issue when dim is not in sorted order * remove debug info * remove debug info * refactor BuildSqueezedDimensions
ManfeiBai pushed a commit that referenced this pull request Nov 29, 2023
* fix squeeze op lowering issue when dim is not in sorted order * remove debug info * remove debug info * refactor BuildSqueezedDimensions
chunnienc pushed a commit to chunnienc/xla that referenced this pull request Dec 14, 2023
…h#5751) * fix squeeze op lowering issue when dim is not in sorted order * remove debug info * remove debug info * refactor BuildSqueezedDimensions
golechwierowicz pushed a commit that referenced this pull request Jan 12, 2024
* fix squeeze op lowering issue when dim is not in sorted order * remove debug info * remove debug info * refactor BuildSqueezedDimensions
bhavya01 pushed a commit that referenced this pull request Apr 22, 2024
* fix squeeze op lowering issue when dim is not in sorted order * remove debug info * remove debug info * refactor BuildSqueezedDimensions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
We notice that torch.ops.aten.sequeeze(tensor, dims) will throw out an error if the dims is not in sorted order after we convert it to Canonical dimensions. Meanwhile if the dims = [-1], it will also throw out an error.
The issue is mostly due to the logic here.
We make the logic fix and add the test case in the pr.