Correct the multinode training doc #5747
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jonb377 reviewed Oct 30, 2023
will-cromar approved these changes Oct 31, 2023
jonb377 reviewed Oct 31, 2023
| | ||
| def train_mnist(flags, **kwargs): | ||
| if flags.ddp: | ||
| if flags.ddp or flags.pjrt_distributed: |
There was a problem hiding this comment.
Ah interesting... Do we need a dedicated flag still, or can we just also check for torchrun some other way? I saw dist.is_torchelastic_launched elsewhere in the codebase: https://github.com/pytorch/xla/blob/83778f0/torch_xla/_internal/rendezvous.py#L20
jonb377 approved these changes Oct 31, 2023
| Thanks for the review! |
mbzomowski pushed a commit to mbzomowski-test-org/xla that referenced this pull request Nov 16, 2023
* fix Jon's comment * add pjrt_distributed flag back. * updated the doc * fix typo * fix typo
ManfeiBai pushed a commit that referenced this pull request Nov 29, 2023
* fix Jon's comment * add pjrt_distributed flag back. * updated the doc * fix typo * fix typo
ManfeiBai pushed a commit that referenced this pull request Nov 29, 2023
* fix Jon's comment * add pjrt_distributed flag back. * updated the doc * fix typo * fix typo
chunnienc pushed a commit to chunnienc/xla that referenced this pull request Dec 14, 2023
* fix Jon's comment * add pjrt_distributed flag back. * updated the doc * fix typo * fix typo
golechwierowicz pushed a commit that referenced this pull request Jan 12, 2024
* fix Jon's comment * add pjrt_distributed flag back. * updated the doc * fix typo * fix typo
bhavya01 pushed a commit that referenced this pull request Apr 22, 2024
* fix Jon's comment * add pjrt_distributed flag back. * updated the doc * fix typo * fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR
--pjrt_distributedflag back due to Merge--pjrt_distributedflag with--ddpflag. #5732 (comment).