Skip to content

Rectify test_zero1.py once optim.load_state_dict doesn't guarantee immutability #5382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 31, 2023
Merged

Rectify test_zero1.py once optim.load_state_dict doesn't guarantee immutability #5382

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0f139ab
[TEST ONLY] print statements for test_zero1.py to debug
janeyx99 Jul 31, 2023
1cf7b5c
Try fix
janeyx99 Jul 31, 2023
f2d7aef
Rectify test_zero1.py to account for state_dict modification
janeyx99 Jul 31, 2023
2417ef6
Fix lint
janeyx99 Jul 31, 2023
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions test/test_zero1.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
from torch_xla.distributed.zero_redundancy_optimizer import ZeroRedundancyOptimizer
from torch_xla import runtime as xr
from torch.testing._internal.common_utils import TestCase
from copy import deepcopy

import unittest

Expand Down Expand Up @@ -34,18 +35,22 @@ def test_zero1(self):

opt1.step()
opt2.step()
self.assertEqual(opt1.state_dict(), opt2.state_dict()['base'])

s1 = opt1.state_dict()
s2 = opt2.state_dict()
self.assertEqual(s1, s2['base'])

# deepcopy s1 to load later because pytorch optimizers do not guarantee the input
# state_dict will not be modified. on the other hand, s2 has this guarantee.
s1_clone = deepcopy(s1)

opt1.load_state_dict(s1)
opt2.load_state_dict(s2)
self.assertEqual(opt1.state_dict(), opt2.state_dict()['base'])

# step still runnable
opt1.step()
opt2.step()
opt1.load_state_dict(s1)
opt1.load_state_dict(s1_clone)
opt2.load_state_dict(s2)
self.assertEqual(opt1.state_dict(), opt2.state_dict()['base'])

Expand Down