Skip to content

[Dynamo|TPU] Tweak atol and rtol for test_dynamo.py #5363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 27, 2023
Merged

[Dynamo|TPU] Tweak atol and rtol for test_dynamo.py #5363

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6444d62
tweak `atol` and `rtol` for `DynamoTrainingBasicTest.test_simple_model`
ManfeiBai Jul 27, 2023
2077794
tweak the atol and rtol for `DynamoTrainingOptimizerTest.test_simple_…
ManfeiBai Jul 27, 2023
72fa607
format
ManfeiBai Jul 27, 2023
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions test/dynamo/test_dynamo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,21 +231,27 @@ def test_simple_model(self):
res_xla_dynamo = self.fn_simple_dynamo(xla_input)
self.assertIn('xla::nll_loss_backward', met.counter_names())
self.assertTrue(torch.allclose(res_cpu, res_xla_dynamo.cpu()))
self.assertTrue(torch.allclose(input.grad, xla_input.grad.cpu()))
self.assertTrue(
torch.allclose(
input.grad, xla_input.grad.cpu(), rtol=1e-05, atol=1e-04))
# verifiy that tracing is skipped in following runs
xla_input.grad = None
met.clear_counters()
res_xla_dynamo_2 = self.fn_simple_dynamo(xla_input)
self.assertNotIn('xla::nll_loss_backward', met.counter_names())
self.assertTrue(torch.allclose(res_cpu, res_xla_dynamo_2.cpu()))
self.assertTrue(torch.allclose(input.grad, xla_input.grad.cpu()))
self.assertTrue(
torch.allclose(
input.grad, xla_input.grad.cpu(), rtol=1e-05, atol=1e-04))
# verify that dynamo can handle different inputs
input.grad = None
xla_input.grad = None
res_xla_dynamo_3 = self.fn_simple_dynamo(xla_input * 2)
res_cpu_3 = self.fn_simple(input * 2)
self.assertTrue(torch.allclose(res_cpu_3, res_xla_dynamo_3.cpu()))
self.assertTrue(torch.allclose(input.grad, xla_input.grad.cpu()))
self.assertTrue(
torch.allclose(
input.grad, xla_input.grad.cpu(), rtol=1e-05, atol=1e-04))

def test_resnet18(self):
torch._dynamo.reset()
Expand Down Expand Up @@ -343,7 +349,8 @@ def test_simple_model(self):
res_cpu = self.fn_simple(input, optimizer)
res_xla_dynamo = self.fn_simple_dynamo(xla_input, xla_optimizer)
assert torch.allclose(res_cpu, res_xla_dynamo.cpu())
assert torch.allclose(input.grad, xla_input.grad.cpu())
assert torch.allclose(
input.grad, xla_input.grad.cpu(), rtol=1e-04, atol=1e-04)
assert torch.allclose(input, xla_input.cpu())

def test_resnet18(self):
Expand Down